Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingestion/vertica): support columns with timestamp precision #6295

Merged
merged 8 commits into from
Dec 7, 2022
Merged

fix(ingestion/vertica): support columns with timestamp precision #6295

merged 8 commits into from
Dec 7, 2022

Conversation

inancdokurel
Copy link
Contributor

@inancdokurel inancdokurel commented Oct 26, 2022 •
edited by hsheth2
Loading

Fixes #5295

It is not a perfect fix, however it allows timestamp fields with precision values to be ingested into Datahub

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Oct 26, 2022
@shirshanka shirshanka added hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ community-contribution PR or Issue raised by member(s) of DataHub Community labels Oct 27, 2022
@github-actions
Copy link

github-actions bot commented Oct 27, 2022 •
edited
Loading

Unit Test Results (metadata ingestion)

       8 files         8 suites   1h 5m 17s ⏱️
   752 tests    750 ✔️ 2 💤 0 ❌
1 506 runs  1 501 ✔️ 5 💤 0 ❌

Results for commit fa90711.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 27, 2022 •
edited
Loading

Unit Test Results (build & test)

633 tests  +12   629 ✔️ +12   15m 45s ⏱️ -4s
162 suites +  5       4 💤 ±  0 
162 files   +  5       0 ❌ ±  0 

Results for commit fa90711. ± Comparison against base commit f69b469.

This pull request removes 4 and adds 16 tests. Note that renamed tests count towards both. 
com.datahub.authorization.ranger.RangerAuthorizerTest ‑ testAuthorizationAllow
com.datahub.authorization.ranger.RangerAuthorizerTest ‑ testAuthorizationDeny
com.datahub.authorizer.plugin.ranger.TestDataHubRangerAuthPlugin ‑ testLookupResource
com.datahub.authorizer.plugin.ranger.TestDataHubRangerAuthPlugin ‑ testValidateConfig

com.datahub.plugins.auth.TestConfig ‑ testConfig
com.datahub.plugins.auth.TestConfigProvider ‑ testConfigurationLoading
com.datahub.plugins.auth.TestConfigValidationUtils ‑ testListShouldNotBeEmpty
com.datahub.plugins.auth.TestConfigValidationUtils ‑ testListShouldNotHaveDuplicate
com.datahub.plugins.auth.TestConfigValidationUtils ‑ testMapShouldNotBeEmpty
com.datahub.plugins.auth.TestConfigValidationUtils ‑ testWhiteSpacesValidation
com.datahub.plugins.auth.TestIsolatedClassLoader ‑ testAuthenticatorPlugin
com.datahub.plugins.auth.TestIsolatedClassLoader ‑ testAuthorizerPlugin
com.datahub.plugins.auth.TestIsolatedClassLoader ‑ testDuplicatePluginName
com.datahub.plugins.auth.TestIsolatedClassLoader ‑ testIncorrectImplementation
…

♻️ This comment has been updated with latest results.

@inancdokurel
Copy link
Contributor Author

Anybody willing to review and provide comments?

hsheth2
hsheth2 requested changes Dec 6, 2022
View reviewed changes
Copy link
Collaborator

@hsheth2 hsheth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about the delay in review

This mostly looks good, but I've added two small comments

metadata-ingestion/src/datahub/ingestion/source/sql/vertica.py Show resolved Hide resolved
metadata-ingestion/src/datahub/ingestion/source/sql/vertica.py Outdated Show resolved Hide resolved
@inancdokurel inancdokurel requested a review from hsheth2 December 7, 2022 15:48
hsheth2
hsheth2 approved these changes Dec 7, 2022
View reviewed changes
Copy link
Collaborator

@hsheth2 hsheth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hsheth2 hsheth2 changed the title fix(ingestion/vertica): support ingestion of tables with precision field in timestamp values in Vertica fix(ingestion/vertica): support columns with timestamp precision Dec 7, 2022
@hsheth2 hsheth2 merged commit 996dabf into datahub-project:master Dec 7, 2022
cccs-Dustin pushed a commit to CybercentreCanada/datahub that referenced this pull request Feb 1, 2023
@inancdokurel @cccs-Dustin
fix(ingestion/vertica): support columns with timestamp precision (dat…
176359f 
…ahub-project#6295)

Co-authored-by: İnanç Dokurel <[email protected]>
Fixes datahub-project#5295
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

Assignees
No one assigned
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vertica timestamp(0) causes an unable to get column information error in DataHub CLI
3 participants
@inancdokurel @hsheth2 @shirshanka