fix(assertion tab): fixing up regression in assertion resolver #6296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aditya-radhakrishnan
approved these changes
Oct 27, 2022
cccs-tom
pushed a commit
to CybercentreCanada/datahub
that referenced
this pull request
Nov 18, 2022
…ub-project#6296) * fixing up regression in assertion resolver * small nit
cccs-tom
pushed a commit
to CybercentreCanada/datahub
that referenced
this pull request
Nov 18, 2022
…ub-project#6296) * fixing up regression in assertion resolver * small nit
gabe-lyons
added a commit
to gabe-lyons/datahub
that referenced
this pull request
Jun 13, 2023
…ub-project#6296) * fixing up regression in assertion resolver * small nit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr: ce90310
Introduced a change where filter creation added the
.keywordsuffix to the elasticsearch query for status. However, based on the es mapping of this timeseries index, thestatusfield of the assertion run result was not a.keywordfield.Reverting this.
Checklist