Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui) Allow a user to type in a custom value in ingestion Secret Fields #6301

Conversation

chriscollins3456
Copy link
Collaborator

Now allow users to type whatever text they want in secret field while still being able to select from a list of existing secrets and create a secret on the fly.

Do this by changing the input type from Select to AutoComplete with the secrets as options to select and filter down from (if you start typing). If you don't select anything from the dropdown, we store whatever it is that you're typing as your value then.

Things still look the same.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Oct 27, 2022
@github-actions
Copy link

github-actions bot commented Oct 27, 2022

Unit Test Results (build & test)

599 tests  ±0   595 ✔️ ±0   11m 54s ⏱️ +14s
149 suites ±0       4 💤 ±0 
149 files   ±0       0 ±0 

Results for commit 3e29231. ± Comparison against base commit 7b2a76d.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@jjoyce0510 jjoyce0510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the build is green. I see it's a test.

@chriscollins3456 chriscollins3456 merged commit 6aedf67 into datahub-project:master Oct 28, 2022
cccs-tom pushed a commit to CybercentreCanada/datahub that referenced this pull request Nov 18, 2022
cccs-tom pushed a commit to CybercentreCanada/datahub that referenced this pull request Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product PR or Issue related to the DataHub UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants