New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(change-event): add change events for DataProcessInstanceRunEvent #6320

Merged

aditya-radhakrishnan merged 3 commits into datahub-project:master from aditya-radhakrishnan:ar--10-31-dpi-change-event

Nov 1, 2022

Contributor

aditya-radhakrishnan commented Oct 31, 2022 •

edited

Loading

Checklist

The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
Links to related issues (if applicable)
Tests for the changes have been added/updated (if applicable)
Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

github-actions bot added docs product labels

aditya-radhakrishnan changed the title ~~Ar 10 31 dpi change event~~ feat(change-event): add change events for DataProcessInstanceRunEvent

github-actions bot commented Oct 31, 2022 •

edited

Loading

Unit Test Results (build & test)

602 tests +3 598 ✔️ +3 11m 39s ⏱️ -33s
149 suites ±0     4 💤 ±0
149 files ±0     0 ❌ ±0

Results for commit 05a1c74. ± Comparison against base commit 4b31204.

♻️ This comment has been updated with latest results.

jjoyce0510 reviewed

View reviewed changes

metadata-io/src/main/java/com/linkedin/metadata/timeline/TimelineServiceImpl.java Outdated Show resolved Hide resolved

jjoyce0510 reviewed

View reviewed changes

...ava/com/linkedin/metadata/timeline/eventgenerator/AssertionRunEventChangeEventGenerator.java Outdated Show resolved Hide resolved

jjoyce0510 reviewed

View reviewed changes

...ava/com/linkedin/metadata/timeline/eventgenerator/AssertionRunEventChangeEventGenerator.java Outdated Show resolved Hide resolved

jjoyce0510 reviewed

View reviewed changes

...nkedin/metadata/timeline/eventgenerator/DataProcessInstanceRunEventChangeEventGenerator.java Outdated Show resolved Hide resolved

jjoyce0510 reviewed

View reviewed changes

...nkedin/metadata/timeline/eventgenerator/DataProcessInstanceRunEventChangeEventGenerator.java Show resolved Hide resolved

jjoyce0510 reviewed

View reviewed changes

...nkedin/metadata/timeline/eventgenerator/DataProcessInstanceRunEventChangeEventGenerator.java Outdated Show resolved Hide resolved

jjoyce0510 reviewed

View reviewed changes

...nkedin/metadata/timeline/eventgenerator/DataProcessInstanceRunEventChangeEventGenerator.java Outdated

+                      paramsMap.put(DATA_JOB_URN_KEY, parentTemplateUrn.toString());
+                    }
+                  }
+                  return paramsMap;

Collaborator

jjoyce0510 Oct 31, 2022

Overall the event LGTM!

jjoyce0510 reviewed

View reviewed changes

.../src/main/java/com/linkedin/metadata/timeline/eventgenerator/EntityChangeEventGenerator.java Show resolved Hide resolved

jjoyce0510 reviewed

View reviewed changes

.../src/main/java/com/linkedin/metadata/timeline/eventgenerator/EntityChangeEventGenerator.java Outdated Show resolved Hide resolved

jjoyce0510 reviewed

View reviewed changes

...in/java/com/linkedin/metadata/timeline/eventgenerator/EntityChangeEventGeneratorFactory.java Outdated Show resolved Hide resolved

jjoyce0510 reviewed

View reviewed changes

.../src/main/java/com/linkedin/metadata/timeline/eventgenerator/EntityChangeEventGenerator.java Show resolved Hide resolved

jjoyce0510 reviewed

View reviewed changes

...c/main/java/com/linkedin/metadata/timeline/eventgenerator/EntityKeyChangeEventGenerator.java Outdated Show resolved Hide resolved

jjoyce0510 reviewed

View reviewed changes

...mer/src/main/java/com/linkedin/metadata/kafka/hook/event/EntityChangeEventGeneratorHook.java Show resolved Hide resolved

jjoyce0510 reviewed

View reviewed changes

...mer/src/main/java/com/linkedin/metadata/kafka/hook/event/EntityChangeEventGeneratorHook.java Outdated Show resolved Hide resolved

jjoyce0510 reviewed

View reviewed changes

.../mae-consumer/src/test/java/com/linkedin/metadata/kafka/hook/event/PlatformEventMatcher.java Show resolved Hide resolved

jjoyce0510 reviewed

View reviewed changes

...c/main/java/com/linkedin/gms/factory/timeline/EntityChangeEventGeneratorRegistryFactory.java Show resolved Hide resolved

Collaborator

jjoyce0510 commented Oct 31, 2022

Build and test is failing, but great PR. A few minor comments then we are good to go!

aditya-radhakrishnan force-pushed the ar--10-31-dpi-change-event branch from f662410 to e220930 Compare

November 1, 2022 03:48

aditya-radhakrishnan added 3 commits

October 31, 2022 21:35


          refactor(change-events): refactor AspectDiffers to EntityChangeEventG…

a0e931c

…enerators


          feat(change-event): add change events for AssertionRunEvent

14d1d73


          feat(change-event): add change events for DataProcessInstanceRunEvent

05a1c74

aditya-radhakrishnan force-pushed the ar--10-31-dpi-change-event branch from e220930 to 05a1c74 Compare

November 1, 2022 04:36

jjoyce0510 approved these changes

View reviewed changes

Collaborator

jjoyce0510 left a comment

Ship it!

aditya-radhakrishnan merged commit 873b100 into datahub-project:master

aditya-radhakrishnan deleted the ar--10-31-dpi-change-event branch

November 1, 2022 16:53

cccs-tom pushed a commit to CybercentreCanada/datahub that referenced this pull request


          refactor(change-events): refactor AspectDiffers to EntityChangeEventG…

b9c2da9

…enerators (datahub-project#6320)

* refactor(change-events): refactor AspectDiffers to EntityChangeEventGenerators

* feat(change-event): add change events for AssertionRunEvent

* feat(change-event): add change events for DataProcessInstanceRunEvent

cccs-tom pushed a commit to CybercentreCanada/datahub that referenced this pull request


          refactor(change-events): refactor AspectDiffers to EntityChangeEventG…

4611e9e

…enerators (datahub-project#6320)

* refactor(change-events): refactor AspectDiffers to EntityChangeEventGenerators

* feat(change-event): add change events for AssertionRunEvent

* feat(change-event): add change events for DataProcessInstanceRunEvent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels