Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ingest): dbt cloud integration #6323

Merged
merged 22 commits into from
Nov 21, 2022
Merged

feat(ingest): dbt cloud integration #6323

merged 22 commits into from
Nov 21, 2022

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Nov 1, 2022 •
edited
Loading

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added docs Issues and Improvements to docs ingestion PR or Issue related to the ingestion of metadata labels Nov 1, 2022
@github-actions
Copy link

github-actions bot commented Nov 1, 2022 •
edited
Loading

Unit Test Results (metadata ingestion)

       8 files  ±0         8 suites  ±0   55m 30s ⏱️ - 1m 55s
   759 tests ±0     754 ✔️  - 2  3 💤 ±0  2 ❌ +2 
1 520 runs  ±0  1 511 ✔️  - 2  7 💤 ±0  2 ❌ +2 

For more details on these failures, see this check.

Results for commit 05dad4e. ± Comparison against base commit 817406e.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Nov 1, 2022 •
edited
Loading

Unit Test Results (build & test)

621 tests  ±0   617 ✔️ ±0   15m 55s ⏱️ +14s
157 suites ±0       4 💤 ±0 
157 files   ±0       0 ❌ ±0 

Results for commit 05dad4e. ± Comparison against base commit 817406e.

♻️ This comment has been updated with latest results.

@hsheth2 hsheth2 marked this pull request as ready for review November 1, 2022 05:08
@hsheth2 hsheth2 changed the title feat(ingest): dbt cloud support feat(ingest): dbt cloud integration Nov 1, 2022
@hsheth2 hsheth2 requested a review from treff7es November 17, 2022 00:01
treff7es
treff7es approved these changes Nov 17, 2022
View reviewed changes
Copy link
Contributor

@treff7es treff7es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

treff7es
treff7es reviewed Nov 17, 2022
View reviewed changes
Copy link
Contributor

@treff7es treff7es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't see any dependencies set for dbt-cloud in setup.py is it ok this way?

@hsheth2 hsheth2 merged commit 05a0f3e into datahub-project:master Nov 21, 2022
@hsheth2 hsheth2 deleted the dbt-cloud branch November 21, 2022 19:14
cccs-Dustin pushed a commit to CybercentreCanada/datahub that referenced this pull request Feb 1, 2023
@hsheth2 @cccs-Dustin
feat(ingest): dbt cloud integration (datahub-project#6323)
096a6a4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@treff7es treff7es treff7es approved these changes

Assignees
No one assigned
Labels
docs Issues and Improvements to docs ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hsheth2 @treff7es