Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui) Disable deleting Term Groups with children #6332

Conversation

chriscollins3456
Copy link
Collaborator

If a term group has children, disable the ability to delete it from the UI. This is a degradation from another fix, just putting it back to how it was.

Soon we'd like to allow the ability to delete the whole tree underneath the node, but this is a quick revert to the way things used to work.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Nov 1, 2022
Copy link
Collaborator

@jjoyce0510 jjoyce0510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once CI passes, LGTM.

@github-actions
Copy link

github-actions bot commented Nov 1, 2022

Unit Test Results (build & test)

602 tests  ±0   598 ✔️ ±0   11m 37s ⏱️ -13s
149 suites ±0       4 💤 ±0 
149 files   ±0       0 ±0 

Results for commit 06c84c2. ± Comparison against base commit 873b100.

@chriscollins3456 chriscollins3456 merged commit 2374bde into datahub-project:master Nov 1, 2022
cccs-tom pushed a commit to CybercentreCanada/datahub that referenced this pull request Nov 18, 2022
cccs-tom pushed a commit to CybercentreCanada/datahub that referenced this pull request Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product PR or Issue related to the DataHub UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants