fix(ui) Fix filters in embedded list search component #6350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjoyce0510
approved these changes
Nov 2, 2022
cccs-tom
pushed a commit
to CybercentreCanada/datahub
that referenced
this pull request
Nov 18, 2022
…ct#6350) Co-authored-by: Chris Collins <[email protected]>
cccs-tom
pushed a commit
to CybercentreCanada/datahub
that referenced
this pull request
Nov 18, 2022
…ct#6350) Co-authored-by: Chris Collins <[email protected]>
gabe-lyons
pushed a commit
to gabe-lyons/datahub
that referenced
this pull request
Jun 13, 2023
…ct#6350) Co-authored-by: Chris Collins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove filters from
baseParamsso that we can properly remove filters from the EmbeddedListSearch component. If query params are not starting withfilterthen we want to keep them so they don't get overwritten on the Lineage Tab for impact analysis.Checklist