Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ingest): support reserved keywords in model codegen #6351

Merged
merged 1 commit into from
Nov 3, 2022
Merged

feat(ingest): support reserved keywords in model codegen #6351

merged 1 commit into from
Nov 3, 2022

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Nov 2, 2022

Related to acryldata/avro_gen#15

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Nov 2, 2022
jjoyce0510
jjoyce0510 approved these changes Nov 2, 2022
View reviewed changes
Copy link
Collaborator

@jjoyce0510 jjoyce0510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - thanks Harshal!

@github-actions
Copy link

github-actions bot commented Nov 3, 2022

Unit Test Results (build & test)

602 tests  ±0   598 ✔️ ±0   11m 45s ⏱️ -17s
149 suites ±0       4 💤 ±0 
149 files   ±0       0 ❌ ±0 

Results for commit ab2cec7. ± Comparison against base commit aa06f31.

@github-actions
Copy link

github-actions bot commented Nov 3, 2022

Unit Test Results (metadata ingestion)

       8 files         8 suites   58m 32s ⏱️
   756 tests    753 ✔️ 3 💤 0 ❌
1 514 runs  1 508 ✔️ 6 💤 0 ❌

Results for commit ab2cec7.

@jjoyce0510 jjoyce0510 merged commit 0ca3383 into datahub-project:master Nov 3, 2022
@hsheth2 hsheth2 deleted the avro-reserved-keywords branch November 3, 2022 06:23
cccs-tom pushed a commit to CybercentreCanada/datahub that referenced this pull request Nov 18, 2022
@hsheth2 @cccs-tom
feat(ingest): support reserved keywords in model codegen (datahub-pro…
bc1d850 
…ject#6351)
cccs-tom pushed a commit to CybercentreCanada/datahub that referenced this pull request Nov 18, 2022
@hsheth2 @cccs-tom
feat(ingest): support reserved keywords in model codegen (datahub-pro…
ca9f782 
…ject#6351)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjoyce0510 jjoyce0510 jjoyce0510 approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hsheth2 @jjoyce0510