refactor(ui): Refactor the Glossary Related Entities, Tag Profiles to use search filters instead of query API. #6352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjoyce0510
force-pushed
the
jj--fix-related-entities-tab-filters
branch
from
4d8fa0a to
2e94fe8
Compare
| // responds. | ||
| export const removeFixedFiltersFromFacets = (fixedFilters: FilterSet, facets: FacetMetadata[]) => { | ||
| const fixedFields = fixedFilters.filters.map((filter) => filter.field); | ||
| return facets.filter((facet) => !(fixedFields.indexOf(facet.field) > -1)); |
There was a problem hiding this comment.
definitely a nit and not expecting you to change this - but could use .includes here as I think that's more readable (facets.filter(facet => !fixedFields.includes(facet.field))
….com/jjoyce0510/datahub-1 into jj--fix-related-entities-tab-filters
anshbansal
pushed a commit
to acryldata/datahub
that referenced
this pull request
Nov 4, 2022
… use search filters instead of query API. (datahub-project#6352)
cccs-tom
pushed a commit
to CybercentreCanada/datahub
that referenced
this pull request
Nov 18, 2022
… use search filters instead of query API. (datahub-project#6352)
cccs-tom
pushed a commit
to CybercentreCanada/datahub
that referenced
this pull request
Nov 18, 2022
… use search filters instead of query API. (datahub-project#6352)
gabe-lyons
pushed a commit
to gabe-lyons/datahub
that referenced
this pull request
Jun 13, 2023
… use search filters instead of query API. (datahub-project#6352)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In this PR we remove dependency on the search query string for looking up entities related to a given glossary term or tag. This makes the result set much more reliable, as previously special characters in the URN of a glossary or tag URN could cause failures to match at the indexing layer (do to how we tokenize the urn). This fixes those issues.
Status
Ready to Review. Working on some final cypress tests to cover this.
Checklist