Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest): only log vars if requested #6362

Merged
merged 2 commits into from
Nov 4, 2022
Merged

fix(ingest): only log vars if requested #6362

merged 2 commits into from
Nov 4, 2022

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Nov 3, 2022 •
edited
Loading

Adds a global --debug-vars flag, which is disabled by default. Removes the SensitiveError type, which was producing confusing error messages.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Nov 3, 2022
@github-actions
Copy link

github-actions bot commented Nov 3, 2022

Unit Test Results (build & test)

613 tests   609 ✔️  11m 48s ⏱️
151 suites      4 💤
151 files        0 ❌

Results for commit 9a1e690.

@github-actions
Copy link

github-actions bot commented Nov 3, 2022

Unit Test Results (metadata ingestion)

       8 files         8 suites   57m 35s ⏱️
   756 tests    753 ✔️ 3 💤 0 ❌
1 514 runs  1 507 ✔️ 7 💤 0 ❌

Results for commit 9a1e690.

shirshanka
shirshanka approved these changes Nov 4, 2022
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hsheth2 hsheth2 merged commit 3080b9e into datahub-project:master Nov 4, 2022
@hsheth2 hsheth2 deleted the logging-vars branch November 4, 2022 03:16
anshbansal pushed a commit to acryldata/datahub that referenced this pull request Nov 4, 2022
@hsheth2 @anshbansal
fix(ingest): only log vars if requested (datahub-project#6362)
5b69a9c
cccs-tom pushed a commit to CybercentreCanada/datahub that referenced this pull request Nov 18, 2022
@hsheth2 @cccs-tom
fix(ingest): only log vars if requested (datahub-project#6362)
8d57945
cccs-tom pushed a commit to CybercentreCanada/datahub that referenced this pull request Nov 18, 2022
@hsheth2 @cccs-tom
fix(ingest): only log vars if requested (datahub-project#6362)
462fe79
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hsheth2 @shirshanka