Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(mae-consumer): Set proper variable expansion for JMX_OPTS and JAVA_OPTS in MAE docker #6378

Merged
merged 1 commit into from
Nov 15, 2022
Merged

fix(mae-consumer): Set proper variable expansion for JMX_OPTS and JAVA_OPTS in MAE docker #6378

merged 1 commit into from
Nov 15, 2022

Conversation

skrydal
Copy link
Collaborator

@skrydal skrydal commented Nov 7, 2022

JMX_OPTS and JAVA_OPTS are properly expanded in start.sh script of MAE docker image. Before they were missing dollar sign ($) and instead of being expanded, in case they were defined, they were passed as strings causing exception like below in MAE container:

Picked up JAVA_TOOL_OPTIONS:  JMX_OPTS
Unrecognized option: JMX_OPTS
Error: Could not create the Java Virtual Machine.
Error: A fatal exception has occurred. Program will exit.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the devops PR or Issue related to DataHub backend & deployment label Nov 7, 2022
@skrydal skrydal changed the title fix: Set proper variable expansion for JMX_OPTS and JAVA_OPTS in MAE docker fix(mae-consumer): Set proper variable expansion for JMX_OPTS and JAVA_OPTS in MAE docker Nov 7, 2022
@github-actions
Copy link

github-actions bot commented Nov 7, 2022 •
edited
Loading

Unit Test Results (build & test)

613 tests   609 ✔️  11m 19s ⏱️
151 suites      4 💤
151 files        0 ❌

Results for commit de91bd4.

♻️ This comment has been updated with latest results.

@maggiehays maggiehays added the community-contribution PR or Issue raised by member(s) of DataHub Community label Nov 14, 2022
@pedro93 pedro93 force-pushed the fix-mae-docker-java-opts branch from 5942913 to de91bd4 Compare November 15, 2022 15:11
@pedro93
Copy link
Collaborator

pedro93 commented Nov 15, 2022

Hello @skrydal
Thank you for your PR! I just rebased your branch to re-run the CI system and make sure this PR won't break anything.

@pedro93 pedro93 self-assigned this Nov 15, 2022
jjoyce0510
jjoyce0510 approved these changes Nov 15, 2022
View reviewed changes
Copy link
Collaborator

@jjoyce0510 jjoyce0510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thank you!

@jjoyce0510 jjoyce0510 merged commit a274406 into datahub-project:master Nov 15, 2022
cccs-Dustin pushed a commit to CybercentreCanada/datahub that referenced this pull request Feb 1, 2023
@skrydal @cccs-Dustin
fix(docker): Set proper variable expansion for JMX_OPTS and JAVA_OPTS…
7371d9e 
… in MAE docker (datahub-project#6378)

image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjoyce0510 jjoyce0510 jjoyce0510 approved these changes

Assignees

@pedro93 pedro93

Labels
community-contribution PR or Issue raised by member(s) of DataHub Community devops PR or Issue related to DataHub backend & deployment
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@skrydal @pedro93 @jjoyce0510 @maggiehays