Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added functionality to copy fieldpath and urn of each column #6398

Merged
merged 2 commits into from
Nov 15, 2022
Merged

Added functionality to copy fieldpath and urn of each column #6398

merged 2 commits into from
Nov 15, 2022

Conversation

Ankit-Keshari-Vituity
Copy link
Contributor

@Ankit-Keshari-Vituity Ankit-Keshari-Vituity commented Nov 10, 2022 •
edited
Loading

Checklist

copy_dropdown

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Nov 10, 2022
@github-actions
Copy link

github-actions bot commented Nov 10, 2022 •
edited
Loading

Unit Test Results (build & test)

613 tests  ±0   609 ✔️ ±0   12m 2s ⏱️ +4s
151 suites ±0       4 💤 ±0 
151 files   ±0       0 ❌ ±0 

Results for commit 26e8348. ± Comparison against base commit ae2ea52.

♻️ This comment has been updated with latest results.

jjoyce0510
jjoyce0510 reviewed Nov 15, 2022
View reviewed changes
datahub-web-react/src/app/entity/shared/tabs/Dataset/Schema/components/MenuColumn.tsx Outdated
<Menu.Item key="2">
<MenuItem
onClick={() => {
navigator.clipboard.writeText(urn);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm afraid that this is going to copy the entity urn not the column urn.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Using generateSchemaFieldUrn function to get the URN of the column.

chriscollins3456
chriscollins3456 approved these changes Nov 15, 2022
View reviewed changes
Copy link
Collaborator

@chriscollins3456 chriscollins3456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good with the new change!

@chriscollins3456 chriscollins3456 merged commit fc26cf3 into datahub-project:master Nov 15, 2022
cccs-Dustin pushed a commit to CybercentreCanada/datahub that referenced this pull request Feb 1, 2023
@Ankit-Keshari-Vituity @cccs-Dustin
feat(ui) Added functionality to copy fieldpath and urn of each column (…
95406ac 
…datahub-project#6398)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjoyce0510 jjoyce0510 jjoyce0510 left review comments

@chriscollins3456 chriscollins3456 chriscollins3456 approved these changes

Assignees
No one assigned
Labels
product PR or Issue related to the DataHub UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ankit-Keshari-Vituity @jjoyce0510 @chriscollins3456