Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ingest): add config for ingesting delta table without files #6403

Merged
merged 4 commits into from
Nov 22, 2022
Merged

feat(ingest): add config for ingesting delta table without files #6403

merged 4 commits into from
Nov 22, 2022

Conversation

mayurinehate
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Nov 10, 2022
@mayurinehate mayurinehate force-pushed the delta_lake_memory_reduction branch from 01c5f20 to a719297 Compare November 10, 2022 12:31
@github-actions
Copy link

github-actions bot commented Nov 10, 2022 •
edited
Loading

Unit Test Results (metadata ingestion)

       8 files         8 suites   57m 38s ⏱️
   761 tests    758 ✔️ 3 💤 0 ❌
1 524 runs  1 517 ✔️ 7 💤 0 ❌

Results for commit 07a7fc9.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Nov 10, 2022 •
edited
Loading

Unit Test Results (build & test)

621 tests  ±0   617 ✔️ ±0   15m 44s ⏱️ -4s
157 suites ±0       4 💤 ±0 
157 files   ±0       0 ❌ ±0 

Results for commit 07a7fc9. ± Comparison against base commit 317f0b1.

♻️ This comment has been updated with latest results.

@mayurinehate mayurinehate force-pushed the delta_lake_memory_reduction branch from 7474b36 to 24eb82d Compare November 15, 2022 06:34
@mayurinehate mayurinehate force-pushed the delta_lake_memory_reduction branch from 24eb82d to 796afe8 Compare November 21, 2022 18:02
@mayurinehate mayurinehate force-pushed the delta_lake_memory_reduction branch from 796afe8 to 71e7463 Compare November 21, 2022 18:05
hsheth2
hsheth2 reviewed Nov 22, 2022
View reviewed changes
Copy link
Collaborator

@hsheth2 hsheth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nit but LGTM other than that

metadata-ingestion/src/datahub/ingestion/source/delta_lake/source.py Outdated Show resolved Hide resolved
metadata-ingestion/src/datahub/ingestion/source/delta_lake/source.py Outdated Show resolved Hide resolved
@hsheth2 hsheth2 assigned hsheth2 and unassigned treff7es Nov 22, 2022
@hsheth2 hsheth2 merged commit e085a9e into datahub-project:master Nov 22, 2022
cccs-Dustin pushed a commit to CybercentreCanada/datahub that referenced this pull request Feb 1, 2023
@mayurinehate @cccs-Dustin
feat(ingest): add config for ingesting delta table without files (dat…
056bba5 
…ahub-project#6403)

Closes undefined
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

Assignees

@hsheth2 hsheth2

Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

delta-lake: requires lots of memory to process files
3 participants
@mayurinehate @hsheth2 @treff7es