Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui) Improve HoverEntityTooltip and truncate parent glossary nodes #6417

Conversation

chriscollins3456
Copy link
Collaborator

Fixes a bad UX situation in the HoverEntityTooltip where a glossary term has lots of parents and it would cause them to get squished and bleed over to the side with owners by truncating them when they get too long just like we do with parent containers. If you hover over the ellipses we show you the whole path (like containers).

This also increases the maxWidth of this tooltip to allow for some more room when there's lots of content to show. We also still increase the width of the left side content when there's no Owners, so that situation will look good too.

Here's what it was before:
image

and what it looks like now:
image

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Nov 11, 2022
@github-actions
Copy link

github-actions bot commented Nov 11, 2022

Unit Test Results (build & test)

613 tests  ±0   609 ✔️ ±0   12m 2s ⏱️ +18s
151 suites ±0       4 💤 ±0 
151 files   ±0       0 ±0 

Results for commit ef6057c. ± Comparison against base commit 3e907ab.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@jjoyce0510 jjoyce0510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@chriscollins3456 chriscollins3456 merged commit 78c3bf9 into datahub-project:master Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product PR or Issue related to the DataHub UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants