Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(elasticsearch): Optimize search relavancy #6423

Closed
wants to merge 18 commits into from
Closed

feat(elasticsearch): Optimize search relavancy #6423

wants to merge 18 commits into from

Conversation

david-leifker
Copy link
Collaborator

@david-leifker david-leifker commented Nov 14, 2022 •
edited
Loading

  • Stemming
  • Synonyms
  • URN (full or partial) search
  • Autocomplete improvements
  • Adds test fixture for search tests
  • Updates ES to 7.10 from 7.9

Built on PR 6269

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

david-leifker and others added 6 commits November 3, 2022 08:05
@david-leifker
feat(elasticsearch): Updates to elasticsearch configuration, dao, and…
b8ef061 
… tests
@david-leifker
feat(elasticsearch): Updates to elasticsearch configuration, dao, and…
3f8dbb7 
… tests
@david-leifker
Merge branch 'master' into david-leifker/elasticsearch-improvements
cf7f57e
@david-leifker
Merge remote-tracking branch 'origin/master' into david-leifker/elast…
5775e97 
…icsearch-improvements

# Conflicts:
#	metadata-ingestion/setup.py
#	metadata-integration/java/spark-lineage/spark-smoke-test/golden_json/JavaHdfsIn2HiveCreateInsertTable.json
#	metadata-integration/java/spark-lineage/spark-smoke-test/golden_json/PythonHdfsIn2HiveCreateInsertTable.json
#	metadata-integration/java/spark-lineage/spark-smoke-test/smoke.sh
@david-leifker
Merge branch 'david-leifker/elasticsearch-improvements' into david-le…
96c6b6d 
…ifker/elastisearch-optimization

# Conflicts:
#	metadata-ingestion/setup.py
#	metadata-integration/java/spark-lineage/spark-smoke-test/golden_json/JavaHdfsIn2HiveCreateInsertTable.json
#	metadata-integration/java/spark-lineage/spark-smoke-test/golden_json/PythonHdfsIn2HiveCreateInsertTable.json
#	metadata-integration/java/spark-lineage/spark-smoke-test/smoke.sh
#	metadata-jobs/mae-consumer/src/main/java/com/linkedin/metadata/kafka/hook/UpdateIndicesHook.java
@david-leifker
feat(elasticsearch): Improvements to search relevancy, add synoynms, …
1927685 
…stemming
@github-actions github-actions bot added devops PR or Issue related to DataHub backend & deployment ingestion PR or Issue related to the ingestion of metadata product PR or Issue related to the DataHub UI/UX labels Nov 14, 2022
@github-actions
Copy link

github-actions bot commented Nov 14, 2022 •
edited
Loading

Unit Test Results (metadata ingestion)

       8 files  ±0         8 suites  ±0   1h 1m 47s ⏱️ + 1m 21s
   752 tests ±0     749 ✔️  - 1  2 💤 ±0  1 ❌ +1 
1 506 runs  ±0  1 500 ✔️  - 1  5 💤 ±0  1 ❌ +1 

For more details on these failures, see this check.

Results for commit 82b9f64. ± Comparison against base commit eeb7a9d.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Nov 14, 2022 •
edited
Loading

Unit Test Results (build & test)

357 tests   - 276   357 ✔️  - 272   51s ⏱️ - 14m 56s
  97 suites  -   65       0 💤  -     4 
  97 files    -   65       0 ❌ ±    0 

Results for commit 82b9f64. ± Comparison against base commit eeb7a9d.

This pull request removes 276 tests. 
com.datahub.authentication.authenticator.AuthenticatorChainTest ‑ testAuthenticateFailure
com.datahub.authentication.authenticator.AuthenticatorChainTest ‑ testAuthenticateSuccess
com.datahub.authentication.authenticator.AuthenticatorChainTest ‑ testAuthenticateThrows
com.datahub.authentication.authenticator.DataHubSystemAuthenticatorTest ‑ testAuthenticateFailureMismatchingCredentials
com.datahub.authentication.authenticator.DataHubSystemAuthenticatorTest ‑ testAuthenticateFailureMissingAuthorizationHeader
com.datahub.authentication.authenticator.DataHubSystemAuthenticatorTest ‑ testAuthenticateFailureMissingBasicCredentials
com.datahub.authentication.authenticator.DataHubSystemAuthenticatorTest ‑ testAuthenticateSuccessDelegatedActor
com.datahub.authentication.authenticator.DataHubSystemAuthenticatorTest ‑ testAuthenticateSuccessNoDelegatedActor
com.datahub.authentication.authenticator.DataHubSystemAuthenticatorTest ‑ testInit
com.datahub.authentication.authenticator.DataHubTokenAuthenticatorTest ‑ testAuthenticateFailureInvalidToken
…

♻️ This comment has been updated with latest results.

@david-leifker david-leifker marked this pull request as draft November 14, 2022 23:34
@david-leifker david-leifker added the wip Work in progress, don't review yet label Nov 17, 2022
@david-leifker david-leifker force-pushed the david-leifker/elastisearch-optimization branch from 18e6b81 to af7a924 Compare November 23, 2022 00:27
@aditya-radhakrishnan aditya-radhakrishnan removed ingestion PR or Issue related to the ingestion of metadata product PR or Issue related to the DataHub UI/UX labels Dec 19, 2022
@aditya-radhakrishnan aditya-radhakrishnan added the platform PR-s that make changes to core parts of the platform label Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanHolstien RyanHolstien Awaiting requested review from RyanHolstien

@gabe-lyons gabe-lyons Awaiting requested review from gabe-lyons

Assignees
No one assigned
Labels
devops PR or Issue related to DataHub backend & deployment platform PR-s that make changes to core parts of the platform wip Work in progress, don't review yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@david-leifker @aditya-radhakrishnan