Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(change-event): remove unnecessary dependencies on EntityChangeEventGeneratorRegistryFactory #6431

Merged
merged 1 commit into from
Nov 14, 2022
Merged

fix(change-event): remove unnecessary dependencies on EntityChangeEventGeneratorRegistryFactory #6431

merged 1 commit into from
Nov 14, 2022

Conversation

aditya-radhakrishnan
Copy link
Contributor

@aditya-radhakrishnan aditya-radhakrishnan commented Nov 14, 2022 •
edited
Loading

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@aditya-radhakrishnan aditya-radhakrishnan added the product PR or Issue related to the DataHub UI/UX label Nov 14, 2022
@github-actions
Copy link

Unit Test Results (build & test)

613 tests  +613   609 ✔️ +609   11m 44s ⏱️ + 11m 44s
151 suites +151       4 💤 +    4 
151 files   +151       0 ❌ ±    0 

Results for commit bdbc836. ± Comparison against base commit 198c86a.

@aditya-radhakrishnan aditya-radhakrishnan merged commit 2a4ec99 into datahub-project:master Nov 14, 2022
@aditya-radhakrishnan aditya-radhakrishnan deleted the ar--event-dependencies branch November 14, 2022 20:40
cccs-Dustin pushed a commit to CybercentreCanada/datahub that referenced this pull request Feb 1, 2023
@aditya-radhakrishnan @cccs-Dustin
fix(change-event): remove unnecessary dependencies on EntityChangeEve…
a2df430 
…ntGeneratorRegistryFactory (datahub-project#6431)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjoyce0510 jjoyce0510 jjoyce0510 approved these changes

Assignees
No one assigned
Labels
product PR or Issue related to the DataHub UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aditya-radhakrishnan @jjoyce0510