Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(roles): allows role service to unassign roles #6434

Merged
merged 1 commit into from
Nov 17, 2022
Merged

fix(roles): allows role service to unassign roles #6434

merged 1 commit into from
Nov 17, 2022

Conversation

aditya-radhakrishnan
Copy link
Contributor

@aditya-radhakrishnan aditya-radhakrishnan commented Nov 14, 2022 •
edited
Loading

Screenshot

image
Admins can now remove roles, or send an invite link with No Role attached to remove a role from a user

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Nov 14, 2022
@aditya-radhakrishnan aditya-radhakrishnan added product PR or Issue related to the DataHub UI/UX and removed product PR or Issue related to the DataHub UI/UX labels Nov 14, 2022
@github-actions
Copy link

github-actions bot commented Nov 14, 2022 •
edited
Loading

Unit Test Results (build & test)

621 tests   - 1   617 ✔️  - 1   15m 43s ⏱️ -20s
157 suites ±0       4 💤 ±0 
157 files   ±0       0 ❌ ±0 

Results for commit 18ea936. ± Comparison against base commit 1fe0f01.

This pull request removes 7 and adds 6 tests. Note that renamed tests count towards both. 
com.datahub.authorization.RoleServiceTest ‑ testAssignRoleToActorDoesNotExist
com.datahub.authorization.RoleServiceTest ‑ testAssignRoleToActorExists
com.datahub.authorization.RoleServiceTest ‑ testRoleDoesNotExist
com.datahub.authorization.RoleServiceTest ‑ testRoleExists
com.linkedin.datahub.graphql.resolvers.role.BatchAssignRoleResolverTest ‑ testAllActorsExist
com.linkedin.datahub.graphql.resolvers.role.BatchAssignRoleResolverTest ‑ testRoleDoesNotExistFails
com.linkedin.datahub.graphql.resolvers.role.BatchAssignRoleResolverTest ‑ testSomeActorsExist

com.datahub.authorization.RoleServiceTest ‑ testAssignNullRoleToActorAllActorsExist
com.datahub.authorization.RoleServiceTest ‑ testBatchAssignRoleAllActorsExist
com.datahub.authorization.RoleServiceTest ‑ testBatchAssignRoleNoActorExists
com.datahub.authorization.RoleServiceTest ‑ testBatchAssignRoleSomeActorExists
com.linkedin.datahub.graphql.resolvers.role.BatchAssignRoleResolverTest ‑ testNotNullRole
com.linkedin.datahub.graphql.resolvers.role.BatchAssignRoleResolverTest ‑ testNullRole

♻️ This comment has been updated with latest results.

@aditya-radhakrishnan aditya-radhakrishnan mentioned this pull request Nov 15, 2022
Closed
4 tasks
@aditya-radhakrishnan
Copy link
Contributor Author

Big shout out to @samanthafigueredo5 for catching two bugs here - not reflecting cancellation of role assignment, and fixing up the listRoles query made on the frontend! We really appreciate it :)

chriscollins3456
chriscollins3456 approved these changes Nov 15, 2022
View reviewed changes
Copy link
Collaborator

@chriscollins3456 chriscollins3456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking solid to me!

...-core/src/main/java/com/linkedin/datahub/graphql/resolvers/role/BatchAssignRoleResolver.java Show resolved Hide resolved
...raphql-core/src/main/java/com/linkedin/datahub/graphql/resolvers/role/ListRolesResolver.java Show resolved Hide resolved
datahub-web-react/src/app/identity/user/UserList.tsx Show resolved Hide resolved
metadata-service/auth-impl/src/main/java/com/datahub/authorization/role/RoleService.java Show resolved Hide resolved
datahub-web-react/src/app/identity/user/SelectRole.tsx Outdated Show resolved Hide resolved
@aditya-radhakrishnan aditya-radhakrishnan force-pushed the ar--11-10-remove-role branch 2 times, most recently from 03f6de3 to ec97e24 Compare November 17, 2022 01:57
@aditya-radhakrishnan aditya-radhakrishnan merged commit 6303699 into datahub-project:master Nov 17, 2022
@aditya-radhakrishnan aditya-radhakrishnan deleted the ar--11-10-remove-role branch November 17, 2022 18:59
cccs-Dustin pushed a commit to CybercentreCanada/datahub that referenced this pull request Feb 1, 2023
@aditya-radhakrishnan @cccs-Dustin
fix(roles): allows role service to unassign roles (datahub-project#6434)
497ce6d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjoyce0510 jjoyce0510 jjoyce0510 left review comments

@chriscollins3456 chriscollins3456 chriscollins3456 approved these changes

Assignees
No one assigned
Labels
product PR or Issue related to the DataHub UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aditya-radhakrishnan @jjoyce0510 @chriscollins3456