Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(kafka-setup): Added support for MSK IAM authentication. #6435

Merged
merged 3 commits into from
Nov 22, 2022
Merged

feat(kafka-setup): Added support for MSK IAM authentication. #6435

merged 3 commits into from
Nov 22, 2022

Conversation

pghazanfari
Copy link
Contributor

@pghazanfari pghazanfari commented Nov 14, 2022 •
edited
Loading

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the devops PR or Issue related to DataHub backend & deployment label Nov 14, 2022
@github-actions
Copy link

github-actions bot commented Nov 14, 2022 •
edited
Loading

Unit Test Results (build & test)

613 tests  ±0   609 ✔️ ±0   11m 45s ⏱️ +4s
151 suites ±0       4 💤 ±0 
151 files   ±0       0 ❌ ±0 

Results for commit ae935b4. ± Comparison against base commit d87dcfa.

♻️ This comment has been updated with latest results.

@david-leifker
Copy link
Collaborator

LGTM

@david-leifker david-leifker merged commit 269342b into datahub-project:master Nov 22, 2022
cccs-Dustin pushed a commit to CybercentreCanada/datahub that referenced this pull request Feb 1, 2023
@pghazanfari @cccs-Dustin
feat(kafka-setup): Added support for MSK IAM authentication. (datahub…
695c126 
…-project#6435)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-leifker david-leifker david-leifker approved these changes

Assignees
No one assigned
Labels
devops PR or Issue related to DataHub backend & deployment
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pghazanfari @david-leifker