Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest): correctly compute entity change percentage #6438

Merged
merged 1 commit into from
Nov 15, 2022
Merged

fix(ingest): correctly compute entity change percentage #6438

merged 1 commit into from
Nov 15, 2022

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Nov 15, 2022

Reported https://datahubspace.slack.com/archives/C02FKQAGRG9/p1668487704332469.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Nov 15, 2022
@github-actions
Copy link

Unit Test Results (metadata ingestion)

       8 files  ±0         8 suites  ±0   55m 22s ⏱️ - 2m 14s
   758 tests ±0     755 ✔️ +2  3 💤 ±0  0 ❌  - 2 
1 518 runs  ±0  1 511 ✔️ +2  7 💤 ±0  0 ❌  - 2 

Results for commit 65b6a65. ± Comparison against base commit c6eff28.

shirshanka
shirshanka approved these changes Nov 15, 2022
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

Unit Test Results (build & test)

613 tests  ±0   609 ✔️ ±0   11m 36s ⏱️ -19s
151 suites ±0       4 💤 ±0 
151 files   ±0       0 ❌ ±0 

Results for commit 65b6a65. ± Comparison against base commit c6eff28.

@anshbansal anshbansal merged commit d87dcfa into datahub-project:master Nov 15, 2022
@hsheth2 hsheth2 deleted the stale-entity-thres branch November 15, 2022 17:12
cccs-Dustin pushed a commit to CybercentreCanada/datahub that referenced this pull request Feb 1, 2023
@hsheth2 @cccs-Dustin
fix(ingest): correctly compute entity change percentage (datahub-proj…
38e16da 
…ect#6438)

Reported https://datahubspace.slack.com/archives/C02FKQAGRG9/p1668487704332469.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hsheth2 @shirshanka @anshbansal