Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(datahub-upgrade): Added msk IAM auth as a build dependency. #6439

Merged
merged 2 commits into from
Nov 22, 2022
Merged

feat(datahub-upgrade): Added msk IAM auth as a build dependency. #6439

merged 2 commits into from
Nov 22, 2022

Conversation

pghazanfari
Copy link
Contributor

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions
Copy link

Unit Test Results (build & test)

613 tests  ±0   609 ✔️ ±0   11m 47s ⏱️ -15s
151 suites ±0       4 💤 ±0 
151 files   ±0       0 ❌ ±0 

Results for commit e903c82. ± Comparison against base commit fbcfcfc.

@david-leifker
Copy link
Collaborator

LGTM

@david-leifker david-leifker self-requested a review November 16, 2022 21:06
@pghazanfari
Copy link
Contributor Author

@david-leifker I don't have write access. Would you be able to merge these in?

@david-leifker david-leifker merged commit 497c5ee into datahub-project:master Nov 22, 2022
cccs-Dustin pushed a commit to CybercentreCanada/datahub that referenced this pull request Feb 1, 2023
@pghazanfari @cccs-Dustin
feat(datahub-upgrade): Added msk IAM auth as a build dependency. (dat…
593679d 
…ahub-project#6439)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-leifker david-leifker david-leifker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pghazanfari @david-leifker