feat(ingest): add stateful ingestion support to looker and lookml source #6443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ingestion
hsheth2
reviewed
Nov 16, 2022
metadata-ingestion/src/datahub/ingestion/source/state/looker_state.py
Outdated
Show resolved
Hide resolved
metadata-ingestion/src/datahub/ingestion/source/looker/looker_source.py
Outdated
Show resolved
Hide resolved
Pending - - refractor common test methods , move to test_helpers - lookml source stateful ingestion - update stateful ingestion doc to include improved simpler impl details
mayurinehate
force-pushed
the
looker_stateful_ingestion
branch
from
7fbea59 to
0f20d2d
Compare
mayurinehate
changed the title
hsheth2
approved these changes
Nov 21, 2022
| raise ConfigurationError("Looker Source doesn't support platform instances") | ||
| def platform_instance_not_supported(cls, v: Optional[str]) -> Optional[str]: | ||
| if v is not None: | ||
| raise ConfigurationError("Looker Source doesn't support platform instances") |
There was a problem hiding this comment.
In the future, we should raise value error here instead
5 tasks
cccs-Dustin
pushed a commit
to CybercentreCanada/datahub
that referenced
this pull request
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist