Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest): lowercase db name in mssql ingestion #6448

Merged
merged 2 commits into from
Nov 16, 2022
Merged

fix(ingest): lowercase db name in mssql ingestion #6448

merged 2 commits into from
Nov 16, 2022

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Nov 15, 2022

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Nov 15, 2022
@github-actions
Copy link

github-actions bot commented Nov 15, 2022 •
edited
Loading

Unit Test Results (metadata ingestion)

       8 files  ±0         8 suites  ±0   1h 1m 21s ⏱️ + 4m 36s
   758 tests ±0     753 ✔️  - 2  3 💤 ±0  2 ❌ +2 
1 518 runs  ±0  1 507 ✔️  - 4  7 💤 ±0  4 ❌ +4 

For more details on these failures, see this check.

Results for commit 4e4beeb. ± Comparison against base commit 1ffd241.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Nov 15, 2022 •
edited
Loading

Unit Test Results (build & test)

622 tests  ±0   618 ✔️ ±0   16m 5s ⏱️ +22s
157 suites ±0       4 💤 ±0 
157 files   ±0       0 ❌ ±0 

Results for commit 4e4beeb. ± Comparison against base commit 1ffd241.

♻️ This comment has been updated with latest results.

@treff7es treff7es merged commit cf6fb91 into datahub-project:master Nov 16, 2022
@hsheth2 hsheth2 deleted the mssql-urn-case branch November 17, 2022 17:02
cccs-Dustin pushed a commit to CybercentreCanada/datahub that referenced this pull request Feb 1, 2023
@hsheth2 @cccs-Dustin
fix(ingest): mssql - lowercase db name in mssql ingestion (datahub-pr…
646df78 
…oject#6448)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@treff7es treff7es treff7es approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hsheth2 @treff7es