Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): Introducing Share Button on Entity Pages #6450

Merged

Conversation

jjoyce0510
Copy link
Collaborator

Summary

In this PR we add a "Share" dropdown button on all entity profiles. We also remove the "Copy Url" header menu item.

Screenshots

Screen Shot 2022-11-15 at 5 35 16 PM

Screen Shot 2022-11-15 at 5 35 21 PM

Screen Shot 2022-11-15 at 5 35 26 PM

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Nov 16, 2022
@github-actions
Copy link

github-actions bot commented Nov 17, 2022

Unit Test Results (build & test)

621 tests  ±0   617 ✔️ ±0   16m 17s ⏱️ +18s
157 suites ±0       4 💤 ±0 
157 files   ±0       0 ±0 

Results for commit ec78425. ± Comparison against base commit 970e9f0.

♻️ This comment has been updated with latest results.

@jjoyce0510 jjoyce0510 force-pushed the jj--adding-share-dropdown branch from 421ae2c to 8133fea Compare November 18, 2022 19:03
Copy link
Collaborator

@chriscollins3456 chriscollins3456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not even a single comment - nice addition!

@jjoyce0510 jjoyce0510 merged commit 86798ec into datahub-project:master Nov 22, 2022
cccs-Dustin pushed a commit to CybercentreCanada/datahub that referenced this pull request Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product PR or Issue related to the DataHub UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants