Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(onboarding): adds framework and some steps for onboarding steps UI #6462

Merged
merged 3 commits into from
Dec 8, 2022
Merged

feat(onboarding): adds framework and some steps for onboarding steps UI #6462

merged 3 commits into from
Dec 8, 2022

Conversation

aditya-radhakrishnan
Copy link
Contributor

@aditya-radhakrishnan aditya-radhakrishnan commented Nov 17, 2022 •
edited
Loading

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Nov 17, 2022
@github-actions
Copy link

github-actions bot commented Nov 17, 2022 •
edited
Loading

Unit Test Results (metadata ingestion)

       8 files         8 suites   59m 45s ⏱️
   752 tests    750 ✔️ 2 💤 0 ❌
1 506 runs  1 501 ✔️ 5 💤 0 ❌

Results for commit d446e67.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Nov 17, 2022 •
edited
Loading

Unit Test Results (build & test)

636 tests   632 ✔️  16m 1s ⏱️
164 suites      4 💤
164 files        0 ❌

Results for commit d446e67.

♻️ This comment has been updated with latest results.

chriscollins3456
chriscollins3456 reviewed Nov 17, 2022
View reviewed changes
Copy link
Collaborator

@chriscollins3456 chriscollins3456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! i have a few questions but overall looking solid

...re/src/main/java/com/linkedin/datahub/graphql/resolvers/step/BatchGetStepStatesResolver.java Outdated Show resolved Hide resolved
...b-web-react/src/app/entity/shared/containers/profile/sidebar/Domain/SidebarDomainSection.tsx Outdated Show resolved Hide resolved
datahub-web-react/src/app/onboarding/utils.tsx Outdated Show resolved Hide resolved
datahub-web-react/src/providers/EducationStepsProvider.tsx Outdated Show resolved Hide resolved
@aditya-radhakrishnan aditya-radhakrishnan force-pushed the ar--11-15-onboarding-frontend branch from c1084f1 to 90ff6b3 Compare November 17, 2022 20:09
chriscollins3456
chriscollins3456 approved these changes Nov 17, 2022
View reviewed changes
Copy link
Collaborator

@chriscollins3456 chriscollins3456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good!

chriscollins3456
chriscollins3456 requested changes Nov 17, 2022
View reviewed changes
Copy link
Collaborator

@chriscollins3456 chriscollins3456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pulling my approval barring the styling changes for the welcome step

@chriscollins3456 chriscollins3456 mentioned this pull request Nov 18, 2022
Closed
@aditya-radhakrishnan aditya-radhakrishnan force-pushed the ar--11-15-onboarding-frontend branch 4 times, most recently from 2ff0e84 to cee7213 Compare December 2, 2022 02:56
chriscollins3456
chriscollins3456 reviewed Dec 2, 2022
View reviewed changes
Copy link
Collaborator

@chriscollins3456 chriscollins3456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is looking great! amazing work getting this over the finish line.

I have a few change suggestions but all should be pretty quick and easy to bang out - so nothing big from me

datahub-web-react/src/app/ProtectedRoutes.tsx Outdated Show resolved Hide resolved
datahub-web-react/src/app/onboarding/useUpdateEducationStepIdsAllowlist.tsx Show resolved Hide resolved
datahub-web-react/src/app/onboarding/useUpdateEducationStepIdsAllowlist.tsx Outdated Show resolved Hide resolved
datahub-web-react/src/app/onboarding/OnboardingTour.tsx
onRequestClose={closeTour}
steps={filteredSteps}
isOpen={isOpen}
scrollOffset={-100}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does this do? just curious

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per the docs
image

datahub-web-react/src/app/onboarding/onboarding.tsx Outdated Show resolved Hide resolved
datahub-web-react/src/app/entity/shared/containers/profile/utils.ts Show resolved Hide resolved
datahub-web-react/src/app/onboarding/utils.tsx Show resolved Hide resolved
datahub-web-react/src/app/search/SearchResults.tsx
onChangeFilters={onChangeFilters}
onChangeUnionType={onChangeUnionType}
/>
<div id={SEARCH_RESULTS_FILTERS_ID}>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i hope this doesn't throw off the fix i have for the double scroll situation...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would it?

datahub-web-react/src/providers/EducationStepIdsAllowlistProvider.tsx Outdated Show resolved Hide resolved
jjoyce0510
jjoyce0510 reviewed Dec 3, 2022
View reviewed changes
datahub-web-react/src/app/onboarding/onboarding.tsx Outdated
{
id: GLOBAL_WELCOME_TO_DATAHUB_ID,
content: (
<div>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd recommend extracting this very important step HTML into a separate file so its easy to change!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has been moved!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tytyt

@aditya-radhakrishnan aditya-radhakrishnan force-pushed the ar--11-15-onboarding-frontend branch 3 times, most recently from 00d72ff to cde4f6b Compare December 6, 2022 02:21
jjoyce0510
jjoyce0510 approved these changes Dec 6, 2022
View reviewed changes
Copy link
Collaborator

@jjoyce0510 jjoyce0510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Let's get this in. Any tiny details we will work to iterate on going forward.

Amazing work on this PR, @aditya-radhakrishnan !

@aditya-radhakrishnan aditya-radhakrishnan force-pushed the ar--11-15-onboarding-frontend branch from cde4f6b to 5956960 Compare December 6, 2022 05:05
chriscollins3456
chriscollins3456 approved these changes Dec 6, 2022
View reviewed changes
Copy link
Collaborator

@chriscollins3456 chriscollins3456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice rice man!

@aditya-radhakrishnan aditya-radhakrishnan force-pushed the ar--11-15-onboarding-frontend branch 3 times, most recently from d0e7340 to d047ab0 Compare December 7, 2022 00:43
@aditya-radhakrishnan aditya-radhakrishnan force-pushed the ar--11-15-onboarding-frontend branch from d047ab0 to 1f66284 Compare December 7, 2022 19:12
@aditya-radhakrishnan aditya-radhakrishnan force-pushed the ar--11-15-onboarding-frontend branch from 1f66284 to d446e67 Compare December 7, 2022 22:46
@aditya-radhakrishnan aditya-radhakrishnan merged commit f0f0355 into datahub-project:master Dec 8, 2022
@aditya-radhakrishnan aditya-radhakrishnan deleted the ar--11-15-onboarding-frontend branch December 8, 2022 00:21
cccs-Dustin pushed a commit to CybercentreCanada/datahub that referenced this pull request Feb 1, 2023
@aditya-radhakrishnan @cccs-Dustin
feat(onboarding): adds framework and some steps for onboarding steps …
7ebccad 
…UI (datahub-project#6462)

* feat(onboarding): adds models and API for onboarding steps feature

* feat(onboarding): adds backend for onboarding steps feature

* feat(onboarding): adds framework and some steps for onboarding steps UI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriscollins3456 chriscollins3456 chriscollins3456 approved these changes

@jjoyce0510 jjoyce0510 jjoyce0510 approved these changes

Assignees
No one assigned
Labels
product PR or Issue related to the DataHub UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aditya-radhakrishnan @jjoyce0510 @chriscollins3456