Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ingest): detect old or missing docker compose #6466

Merged
merged 3 commits into from
Nov 17, 2022
Merged

feat(ingest): detect old or missing docker compose #6466

merged 3 commits into from
Nov 17, 2022

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Nov 17, 2022

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Nov 17, 2022
@github-actions
Copy link

github-actions bot commented Nov 17, 2022 •
edited
Loading

Unit Test Results (metadata ingestion)

       8 files         8 suites   57m 11s ⏱️
   758 tests    753 ✔️ 3 💤 2 ❌
1 518 runs  1 507 ✔️ 7 💤 4 ❌

For more details on these failures, see this check.

Results for commit bf7e5b6.

♻️ This comment has been updated with latest results.

shirshanka
shirshanka approved these changes Nov 17, 2022
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

Unit Test Results (build & test)

622 tests  ±0   618 ✔️ ±0   15m 50s ⏱️ -13s
157 suites ±0       4 💤 ±0 
157 files   ±0       0 ❌ ±0 

Results for commit bf7e5b6. ± Comparison against base commit 1fe0f01.

@shirshanka shirshanka merged commit 29c6c43 into datahub-project:master Nov 17, 2022
@hsheth2 hsheth2 deleted the docker-compose-quickstart branch November 17, 2022 18:16
@hsheth2 hsheth2 mentioned this pull request Nov 21, 2022
Closed
cccs-Dustin pushed a commit to CybercentreCanada/datahub that referenced this pull request Feb 1, 2023
@hsheth2 @cccs-Dustin
feat(ingest): detect old or missing docker compose (datahub-project#6466
345d141 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hsheth2 @shirshanka