feat(ui): Adding Explore all button on home page search #6468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriscollins3456
approved these changes
Nov 17, 2022
Comment on lines
+117
to
+121
| && { | ||
| padding: 0px; | ||
| margin: 0px; | ||
| height: 16px; | ||
| } |
There was a problem hiding this comment.
just in general I'm confused why we have these && or &&& all over our css styling... do you understand it?
at least to my understanding, using & is meant to apply styles to the current selector you're on as well as above selectors, so idk if it's really doing anything in these situations, but I could be wrong since I've never seen it used other than with &:hover { ... or some pseudo selector
also I recognize you may be copy pasting this styling from elsewhere lol
There was a problem hiding this comment.
no so for some reason i have to do this to bypass the native antd styles in some cases. would love to understand why
There was a problem hiding this comment.
fricken ant design man
cccs-Dustin
pushed a commit
to CybercentreCanada/datahub
that referenced
this pull request
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding a button for browsing all entities from the Home page. This allows users to start exploring before they know exactly what exists inside of DataHub.
Demo
Screen.Recording.2022-11-16.at.9.57.02.PM.mov
Checklist