Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ui): Simplify base glossary page toolbar #6469

Merged
merged 1 commit into from
Nov 17, 2022
Merged

refactor(ui): Simplify base glossary page toolbar #6469

merged 1 commit into from
Nov 17, 2022

Conversation

jjoyce0510
Copy link
Collaborator

Summary

Removing the duplicative "browse" bar in the Glossary page.

Before:
Screen Shot 2022-11-16 at 10 14 19 PM

After:
Screen Shot 2022-11-16 at 10 13 25 PM

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Nov 17, 2022
@github-actions
Copy link

Unit Test Results (build & test)

622 tests  ±0   618 ✔️ ±0   16m 0s ⏱️ -5s
157 suites ±0       4 💤 ±0 
157 files   ±0       0 ❌ ±0 

Results for commit 50ac193. ± Comparison against base commit 2a791d4.

@jjoyce0510 jjoyce0510 merged commit d35e327 into datahub-project:master Nov 17, 2022
cccs-Dustin pushed a commit to CybercentreCanada/datahub that referenced this pull request Feb 1, 2023
@jjoyce0510 @cccs-Dustin
refactor(ui): Simplify base glossary page (datahub-project#6469)
114db65
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aditya-radhakrishnan aditya-radhakrishnan aditya-radhakrishnan approved these changes

Assignees
No one assigned
Labels
product PR or Issue related to the DataHub UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jjoyce0510 @aditya-radhakrishnan