fix(ingest): kafka - properly picking doc from union type #6472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ingestion
treff7es
changed the title
|
At union types we either have to get the doc from the union's doc itself (if it exists) or if it doesn't then pick it from the non null type's doc. |
shirshanka
reviewed
Nov 17, 2022
| @@ -289,8 +289,14 @@ def emit(self) -> Generator[SchemaField, None, None]: | |||
| ) | |||
|
|
|||
| description = self._description | |||
| if description is None: | |||
| description = schema.props.get("doc", None) | |||
| if self._schema.props.get("doc", None) is None: | |||
There was a problem hiding this comment.
Is there a simpler idiom we could use?
Something like:
schema_description = self._schema_props.get("doc") or actual_schema.props.get("doc")
description = f"{schema_description or ''}{description or ''}"
... rest of code
shirshanka
reviewed
Nov 18, 2022
| @@ -314,6 +322,8 @@ def emit(self) -> Generator[SchemaField, None, None]: | |||
| description = ( | |||
| f"<span style=\"color:red\">DEPRECATED: {merged_props['deprecated']}</span>\n" | |||
| + description | |||
| if description | |||
There was a problem hiding this comment.
doesn't this effectively do the same thing you are trying to prevent above?
If description is None we set it to "" ... so why not just set description to "" above
There was a problem hiding this comment.
A bunch of other integration test expects this property as None and not empty string in their golden files. (like Glue, Hive, etc...) and those broke when I had empty string.
This way the output is identical what we had before.
shirshanka
reviewed
Nov 18, 2022
metadata-ingestion/src/datahub/ingestion/extractor/schema_util.py
Outdated
Show resolved
Hide resolved
hsheth2
reviewed
Nov 18, 2022
metadata-ingestion/src/datahub/ingestion/extractor/schema_util.py
Outdated
Show resolved
Hide resolved
hsheth2
approved these changes
Nov 21, 2022
cccs-Dustin
pushed a commit
to CybercentreCanada/datahub
that referenced
this pull request
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist