Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest/tableau): check tableName existence on datasource response #6478

Merged
merged 2 commits into from
Nov 21, 2022
Merged

fix(ingest/tableau): check tableName existence on datasource response #6478

merged 2 commits into from
Nov 21, 2022

Conversation

lustefaniak
Copy link
Contributor

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Nov 17, 2022
@jjoyce0510 jjoyce0510 requested a review from hsheth2 November 19, 2022 00:34
@github-actions
Copy link

github-actions bot commented Nov 19, 2022 •
edited
Loading

Unit Test Results (metadata ingestion)

       8 files         8 suites   59m 11s ⏱️
   759 tests    756 ✔️ 3 💤 0 ❌
1 520 runs  1 513 ✔️ 7 💤 0 ❌

Results for commit 71f4537.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Nov 19, 2022 •
edited
Loading

Unit Test Results (build & test)

621 tests  ±0   617 ✔️ ±0   15m 38s ⏱️ -21s
157 suites ±0       4 💤 ±0 
157 files   ±0       0 ❌ ±0 

Results for commit 71f4537. ± Comparison against base commit c99ae26a.

♻️ This comment has been updated with latest results.

@hsheth2
Copy link
Collaborator

hsheth2 commented Nov 21, 2022

Thanks for the fix @lustefaniak!

@hsheth2 hsheth2 merged commit bc5e2d4 into datahub-project:master Nov 21, 2022
cccs-Dustin pushed a commit to CybercentreCanada/datahub that referenced this pull request Feb 1, 2023
@lustefaniak @hsheth2 @cccs-Dustin
fix(ingest/tableau): check tableName existence on datasource respon…
e9ee996 
…se (datahub-project#6478)

Co-authored-by: Harshal Sheth <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lustefaniak @hsheth2