Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest): remove redundant types #6486

Merged
merged 2 commits into from
Nov 21, 2022
Merged

fix(ingest): remove redundant types #6486

merged 2 commits into from
Nov 21, 2022

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Nov 18, 2022

Possible since python/typeshed#9220 was merged.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Nov 18, 2022
@github-actions
Copy link

github-actions bot commented Nov 18, 2022 •
edited
Loading

Unit Test Results (metadata ingestion)

       8 files  ±0         8 suites  ±0   58m 55s ⏱️ + 1m 30s
   759 tests ±0     756 ✔️ ±0  3 💤 ±0  0 ❌ ±0 
1 520 runs  ±0  1 513 ✔️ ±0  7 💤 ±0  0 ❌ ±0 

Results for commit c6330bc. ± Comparison against base commit 817406e.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Nov 18, 2022 •
edited
Loading

Unit Test Results (build & test)

621 tests  ±0   617 ✔️ ±0   15m 42s ⏱️ -1s
157 suites ±0       4 💤 ±0 
157 files   ±0       0 ❌ ±0 

Results for commit c6330bc. ± Comparison against base commit 817406e.

♻️ This comment has been updated with latest results.

treff7es
treff7es approved these changes Nov 21, 2022
View reviewed changes
Copy link
Contributor

@treff7es treff7es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@treff7es treff7es merged commit 490097e into datahub-project:master Nov 21, 2022
@hsheth2 hsheth2 deleted the types-click branch November 21, 2022 22:21
anshbansal pushed a commit to acryldata/datahub that referenced this pull request Nov 22, 2022
@hsheth2 @treff7es @anshbansal
fix(ingest): remove redundant types (datahub-project#6486)
8ef414e 
Possible since python/typeshed#9220 was merged.

Co-authored-by: Tamas Nemeth <[email protected]>
cccs-Dustin pushed a commit to CybercentreCanada/datahub that referenced this pull request Feb 1, 2023
@hsheth2 @treff7es @cccs-Dustin
fix(ingest): remove redundant types (datahub-project#6486)
40e707d 
Possible since python/typeshed#9220 was merged.

Co-authored-by: Tamas Nemeth <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@treff7es treff7es treff7es approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hsheth2 @treff7es