Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(cypress): adding local cypress running instructions #6492

Merged
merged 4 commits into from
Nov 18, 2022
Merged

docs(cypress): adding local cypress running instructions #6492

merged 4 commits into from
Nov 18, 2022

Conversation

gabe-lyons
Copy link
Contributor

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions
Copy link

github-actions bot commented Nov 18, 2022 •
edited
Loading

Unit Test Results (build & test)

621 tests  ±0   617 ✔️ ±0   15m 42s ⏱️ -17s
157 suites ±0       4 💤 ±0 
157 files   ±0       0 ❌ ±0 

Results for commit 9a83d4f. ± Comparison against base commit 250f7ce.

♻️ This comment has been updated with latest results.

jjoyce0510
jjoyce0510 reviewed Nov 18, 2022
View reviewed changes
smoke-test/tests/cypress/README.txt Outdated
@@ -0,0 +1,11 @@
# Running Cypress Tests Locally

1. Make sure the packages are installed. It uses some node moduels to run locally. Run `yarn install` from this directory. If you don't have `yarn`, download it.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor typo: modules

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed!

jjoyce0510
jjoyce0510 approved these changes Nov 18, 2022
View reviewed changes
Copy link
Collaborator

@jjoyce0510 jjoyce0510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gabe-lyons gabe-lyons merged commit 62ac91a into datahub-project:master Nov 18, 2022
cccs-Dustin pushed a commit to CybercentreCanada/datahub that referenced this pull request Feb 1, 2023
@gabe-lyons @cccs-Dustin
docs(cypress): adding local cypress running instructions (datahub-pro…
f960fe6 
…ject#6492)

* adding cypress instructions

* adding h1 header for CI

* .md -> .txt

* Update README.txt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-leifker david-leifker david-leifker approved these changes

@jjoyce0510 jjoyce0510 jjoyce0510 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gabe-lyons @jjoyce0510 @david-leifker