Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(managed ingestion): updating snowflake schema pattern placeholder text #6493

Merged
merged 1 commit into from
Nov 18, 2022
Merged

fix(managed ingestion): updating snowflake schema pattern placeholder text #6493

merged 1 commit into from
Nov 18, 2022

Conversation

gabe-lyons
Copy link
Contributor

@gabe-lyons gabe-lyons commented Nov 18, 2022 •
edited
Loading

Follows code from:

https://github.com/datahub-project/datahub/blob/master/metadata-ingestion/src/datahub/ingestion/source/sql/snowflake.py#L925

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@gabe-lyons gabe-lyons changed the title fix(docs): updating snowflake placeholder text fix(managed ingestion): updating snowflake schema pattern placeholder text Nov 18, 2022
@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Nov 18, 2022
chriscollins3456
chriscollins3456 approved these changes Nov 18, 2022
View reviewed changes
Copy link
Collaborator

@chriscollins3456 chriscollins3456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@github-actions
Copy link

Unit Test Results (build & test)

621 tests  ±0   617 ✔️ ±0   15m 45s ⏱️ -14s
157 suites ±0       4 💤 ±0 
157 files   ±0       0 ❌ ±0 

Results for commit 40b7571. ± Comparison against base commit 970e9f0.

@gabe-lyons gabe-lyons merged commit d613cce into datahub-project:master Nov 18, 2022
cccs-Dustin pushed a commit to CybercentreCanada/datahub that referenced this pull request Feb 1, 2023
@gabe-lyons @cccs-Dustin
updating snowflake placeholder text (datahub-project#6493)
acda537
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriscollins3456 chriscollins3456 chriscollins3456 approved these changes

@hsheth2 hsheth2 hsheth2 approved these changes

Assignees
No one assigned
Labels
product PR or Issue related to the DataHub UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gabe-lyons @hsheth2 @chriscollins3456