Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(patch): cover case where patch is used to create an entity #6504

Merged
merged 3 commits into from
Nov 22, 2022
Merged

fix(patch): cover case where patch is used to create an entity #6504

merged 3 commits into from
Nov 22, 2022

Conversation

RyanHolstien
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Nov 21, 2022
@github-actions
Copy link

github-actions bot commented Nov 21, 2022 •
edited
Loading

Unit Test Results (build & test)

621 tests  ±0   617 ✔️ ±0   15m 43s ⏱️ +6s
157 suites ±0       4 💤 ±0 
157 files   ±0       0 ❌ ±0 

Results for commit 8107bba. ± Comparison against base commit fdb74b0.

♻️ This comment has been updated with latest results.

jjoyce0510
jjoyce0510 approved these changes Nov 21, 2022
View reviewed changes
Copy link
Collaborator

@jjoyce0510 jjoyce0510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirshanka shirshanka merged commit 848574d into datahub-project:master Nov 22, 2022
jjoyce0510
jjoyce0510 reviewed Nov 22, 2022
View reviewed changes
metadata-io/src/test/java/com/linkedin/metadata/AspectUtilsTest.java
import static org.mockito.Mockito.*;


public class AspectUtilsTest {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Ryan!

cccs-Dustin pushed a commit to CybercentreCanada/datahub that referenced this pull request Feb 1, 2023
@RyanHolstien @cccs-Dustin
fix(platform): patch for entity creation, honor async flag on request (…
ff5460f 
…datahub-project#6504)
@RyanHolstien RyanHolstien deleted the fix/patchCreate branch March 24, 2023 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjoyce0510 jjoyce0510 jjoyce0510 approved these changes

@shirshanka shirshanka shirshanka left review comments

Assignees
No one assigned
Labels
product PR or Issue related to the DataHub UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RyanHolstien @shirshanka @jjoyce0510