Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest/snowflake): fix lineage allow/deny pattern typo #6506

Merged
merged 1 commit into from
Nov 22, 2022
Merged

fix(ingest/snowflake): fix lineage allow/deny pattern typo #6506

merged 1 commit into from
Nov 22, 2022

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Nov 22, 2022

Slack ref: https://datahubspace.slack.com/archives/CUMUWQU66/p1669089745565739?thread_ts=1669079124.656849&cid=CUMUWQU66

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Nov 22, 2022
@github-actions
Copy link

Unit Test Results (metadata ingestion)

       8 files  ±0         8 suites  ±0   1h 0m 7s ⏱️ + 4m 8s
   761 tests ±0     758 ✔️ +6  3 💤 ±0  0 ❌  - 1 
1 524 runs  ±0  1 517 ✔️ +7  7 💤 ±0  0 ❌  - 2 

Results for commit dbd3a26. ± Comparison against base commit 490097e.

@github-actions
Copy link

Unit Test Results (build & test)

621 tests  ±0   617 ✔️ ±0   16m 5s ⏱️ +22s
157 suites ±0       4 💤 ±0 
157 files   ±0       0 ❌ ±0 

Results for commit dbd3a26. ± Comparison against base commit 490097e.

treff7es
treff7es approved these changes Nov 22, 2022
View reviewed changes
Copy link
Contributor

@treff7es treff7es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@treff7es treff7es merged commit 10a31b1 into datahub-project:master Nov 22, 2022
@hsheth2 hsheth2 deleted the snowflake-lineage-patterns branch November 22, 2022 07:26
anshbansal pushed a commit to acryldata/datahub that referenced this pull request Nov 22, 2022
@hsheth2 @anshbansal
fix(ingest/snowflake): fix lineage allow/deny pattern typo (datahub-p…
c421fce 
…roject#6506)
cccs-Dustin pushed a commit to CybercentreCanada/datahub that referenced this pull request Feb 1, 2023
@hsheth2 @cccs-Dustin
fix(ingest/snowflake): fix lineage allow/deny pattern typo (datahub-p…
03d9b0c 
…roject#6506)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mayurinehate mayurinehate mayurinehate approved these changes

@treff7es treff7es treff7es approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hsheth2 @treff7es @mayurinehate