Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): remove warnings in github actions #6512

Merged
merged 2 commits into from
Nov 23, 2022

Conversation

anshbansal
Copy link
Collaborator

@anshbansal anshbansal commented Nov 22, 2022

This does not completely solve the problem. But 53 warnings -> 21 warnings in docker unified workflow.

ref https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

ref https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/

Asked ishworkh/docker-image-artifact-download#8 regarding a new release with upgrade nodejs version

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the devops PR or Issue related to DataHub backend & deployment label Nov 22, 2022
@github-actions
Copy link

Unit Test Results (build & test)

621 tests  ±0   617 ✔️ ±0   15m 40s ⏱️ -29s
157 suites ±0       4 💤 ±0 
157 files   ±0       0 ±0 

Results for commit e2c0273. ± Comparison against base commit 10a31b1.

@hsheth2
Copy link
Collaborator

hsheth2 commented Nov 22, 2022

While waiting for ishworkh/docker-image-artifact-download#8, we can always reference the exact commit hash instead of the v2 tag.

@anshbansal anshbansal merged commit 0862a22 into datahub-project:master Nov 23, 2022
@anshbansal anshbansal deleted the fix-warnings branch November 23, 2022 11:13
cccs-Dustin pushed a commit to CybercentreCanada/datahub that referenced this pull request Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops PR or Issue related to DataHub backend & deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants