Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(airflow): remove verbose log from airflow plugin #6516

Merged
merged 5 commits into from
Nov 29, 2022
Merged

refactor(airflow): remove verbose log from airflow plugin #6516

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5d25e74
feat(airflow): remove verbose log from airflow plugin
bskim45 Nov 22, 2022
c9f977f
Merge branch 'master' into remove-verbose-log-airflow-provider
bskim45 Nov 22, 2022
4e26016
address comment
bskim45 Nov 26, 2022
6227813
Merge branch 'master' into remove-verbose-log-airflow-provider
bskim45 Nov 26, 2022
4fdd7ac
Addressing lint failures
jjoyce0510 Nov 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions metadata-ingestion/src/datahub_provider/_plugin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,6 @@ def custom_on_success_callback(context):


def task_policy(task: BaseOperator) -> None:
print(f"Setting task policy for Dag: {task.dag_id} Task: {task.task_id}")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we can change it to logger.debug?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4e26016

# task.add_inlets(["auto"])
# task.pre_execute = _wrap_pre_execution(task.pre_execute)
task.on_failure_callback = _wrap_on_failure_callback(task.on_failure_callback)
Expand All @@ -302,8 +301,6 @@ def _patch_policy(settings):


def _patch_datahub_policy():
print("Patching datahub policy")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imo this one should still be logger.info - I believe this one only gets printed once (as opposed to per dag per task), so a higher log level is ok

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4e26016


with contextlib.suppress(ImportError):
import airflow_local_settings

Expand Down