feat(ingest): powerbi # add powerbi workspaces to containers #6532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ingestion
looppi
changed the title
|
@mohdsiddique Pinging for heads up, I've fixed your suggestions. The review may continue. |
anshbansal
added
the
community-contribution
siddiquebagwan
suggested changes
Jan 5, 2023
metadata-ingestion/src/datahub/ingestion/source/powerbi/config.py
Outdated
Show resolved
Hide resolved
5 tasks
jjoyce0510
approved these changes
Jan 18, 2023
|
Oops - looks like there are conflicts. @mohdsiddique can help you sort any out in Slack before merging :) |
|
Fixed, all of the conflicts were from my other PR. |
|
Waiting on CI to do final merge. Cheers! |
jjoyce0510
approved these changes
Jan 24, 2023
ericyomi
pushed a commit
to ericyomi/datahub
that referenced
this pull request
Feb 8, 2023
…-project#6532) Co-authored-by: John Joyce <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conditionally add PowerBI workspace as a container in ingestion, the implementation then adds all of the entities ingested from the workspace to the container.
The workspace name is not delivered outside from the ingestion phase, so it's not possible to achieve similar behavior with transformation steps.
Configuration defaults to not extracting containers.
Checklist