Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ingest): disable stateful_ingestion fail-safe by default #6537

Merged
merged 1 commit into from
Nov 23, 2022
Merged

feat(ingest): disable stateful_ingestion fail-safe by default #6537

merged 1 commit into from
Nov 23, 2022

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Nov 23, 2022

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@hsheth2 hsheth2 changed the title feat(ingest): disable stateful_ingestion failsafe by default feat(ingest): disable stateful_ingestion fail-safe by default Nov 23, 2022
@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Nov 23, 2022
@github-actions
Copy link

Unit Test Results (metadata ingestion)

       8 files         8 suites   1h 1m 38s ⏱️
   764 tests    762 ✔️ 2 💤 0 ❌
1 530 runs  1 525 ✔️ 5 💤 0 ❌

Results for commit f7245c8.

@github-actions
Copy link

Unit Test Results (build & test)

621 tests  ±0   617 ✔️ ±0   15m 51s ⏱️ +8s
157 suites ±0       4 💤 ±0 
157 files   ±0       0 ❌ ±0 

Results for commit f7245c8. ± Comparison against base commit 055196c.

jjoyce0510
jjoyce0510 reviewed Nov 23, 2022
View reviewed changes
metadata-ingestion/src/datahub/ingestion/source/state/stale_entity_removal_handler.py
ge=0.0,
hidden_from_schema=True,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does this do?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That hides the option from the docs site

jjoyce0510
jjoyce0510 approved these changes Nov 23, 2022
View reviewed changes
Copy link
Collaborator

@jjoyce0510 jjoyce0510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this LGTM

@jjoyce0510 jjoyce0510 merged commit 4db51b4 into datahub-project:master Nov 23, 2022
@hsheth2 hsheth2 deleted the stateful-failsafe branch November 23, 2022 20:01
cccs-Dustin pushed a commit to CybercentreCanada/datahub that referenced this pull request Feb 1, 2023
@hsheth2 @cccs-Dustin
feat(ingest): disable stateful_ingestion failsafe by default (datahub…
e603b16 
…-project#6537)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjoyce0510 jjoyce0510 jjoyce0510 approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hsheth2 @jjoyce0510