refactor(recommendations): Filtering for specific entity types in recommendations #6538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabe-lyons
approved these changes
Nov 23, 2022
jjoyce0510
force-pushed
the
jj--filter-entity-types-recommendations
branch
from
8c5e139 to
1e4d012
Compare
cccs-Dustin
pushed a commit
to CybercentreCanada/datahub
that referenced
this pull request
Feb 1, 2023
gabe-lyons
pushed a commit
to gabe-lyons/datahub
that referenced
this pull request
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Recently an issue was introduced wherein we will serve last edited recommendations for ANY entity type. Unfortunately this causes issues for Entity Types which are not well supported by the UI. So to gate this, we are adding a specific set of entity types that are considered "in scope" for recommendations including Most Popular, Recently Viewed, and Recently Edited. This will ensure that entities which are surfaced can be rendered properly by the UI.
Status
Ready for review.
Checklist