Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui): Add Test Connection Support for BigQuery ingestion source #6543

Merged
merged 4 commits into from
Nov 28, 2022
Merged

feat(ui): Add Test Connection Support for BigQuery ingestion source #6543

merged 4 commits into from
Nov 28, 2022

Conversation

jjoyce0510
Copy link
Collaborator

@jjoyce0510 jjoyce0510 commented Nov 24, 2022 •
edited
Loading

Summary

In this PR we add test connection for BigQuery. Verified locally!

Screenshots

Screen Shot 2022-11-23 at 5 16 29 PM

Screen Shot 2022-11-23 at 5 19 40 PM

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Nov 24, 2022
@github-actions
Copy link

Unit Test Results (build & test)

621 tests  ±0   617 ✔️ ±0   15m 46s ⏱️ -18s
157 suites ±0       4 💤 ±0 
157 files   ±0       0 ❌ ±0 

Results for commit 3c3bbe5. ± Comparison against base commit 6255181.

chriscollins3456
chriscollins3456 approved these changes Nov 28, 2022
View reviewed changes
Copy link
Collaborator

@chriscollins3456 chriscollins3456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfecto

@jjoyce0510 jjoyce0510 merged commit 6eb63c2 into datahub-project:master Nov 28, 2022
cccs-Dustin pushed a commit to CybercentreCanada/datahub that referenced this pull request Feb 1, 2023
@jjoyce0510 @cccs-Dustin
feat(ui): Add Test Connection Support for BigQuery ingestion source (d…
6bb92a0 
…atahub-project#6543)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriscollins3456 chriscollins3456 chriscollins3456 approved these changes

Assignees
No one assigned
Labels
product PR or Issue related to the DataHub UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jjoyce0510 @chriscollins3456