feat(ingest): add dummy data source for automated testing #6550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ingestion
hsheth2
previously requested changes
Nov 29, 2022
metadata-ingestion/docs/sources/sample-data/sample-data_recipe.yml
Outdated
Show resolved
Hide resolved
metadata-ingestion/src/datahub/ingestion/source/sample_source.py
Outdated
Show resolved
Hide resolved
jjoyce0510
reviewed
Nov 29, 2022
metadata-ingestion/src/datahub/ingestion/source/sample_source.py
Outdated
Show resolved
Hide resolved
anshbansal
changed the title
jjoyce0510
reviewed
Dec 5, 2022
| @@ -0,0 +1,6 @@ | |||
| source: | |||
| type: dummy-data | |||
There was a problem hiding this comment.
If we are not generalizing this, can we at minimum improve the name.
How about demo-source or quickstart-data-source or something similar. "dummy" doesn't have the best connotation overall
There was a problem hiding this comment.
It was that in the beginning and @treff7es had asked me to change it to dummy
pedro93
approved these changes
Dec 6, 2022
pedro93
dismissed
hsheth2’s stale review
Outdated review that does not have an impact on PR functionality as it is.
5 tasks
cccs-Dustin
pushed a commit
to CybercentreCanada/datahub
that referenced
this pull request
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this is to make it easier to demonstrate end-to-end flow without much external dependencies.
Also moved developing on metadata ingestion doc a bit to make it easier to find.
Checklist