Remove confluent schema registry hard dependency #6552
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ingestion
pedro93
requested review from
anshbansal,
david-leifker,
jjoyce0510 and
shirshanka
pedro93
commented
Nov 25, 2022
pedro93
force-pushed
the
remove-confluent-schema-registry
branch
3 times, most recently
from
2abebfc to
4d32e02
Compare
pedro93
force-pushed
the
remove-confluent-schema-registry
branch
3 times, most recently
from
a00ebdb to
d1afa3f
Compare
pedro93
force-pushed
the
remove-confluent-schema-registry
branch
3 times, most recently
from
d6e47ea to
ad0e4fe
Compare
pedro93
force-pushed
the
remove-confluent-schema-registry
branch
3 times, most recently
from
b3bb2bd to
73910f9
Compare
jjoyce0510
added
platform
RyanHolstien
approved these changes
Jan 18, 2023
pedro93
force-pushed
the
remove-confluent-schema-registry
branch
from
4ced56a to
9caf64d
Compare
pedro93
force-pushed
the
remove-confluent-schema-registry
branch
from
0c546b9 to
e7b264b
Compare
shirshanka
reviewed
Mar 12, 2023
| @ComponentScan(basePackages = {"com.linkedin.metadata.kafka", "com.linkedin.gms.factory.config", | ||
| "com.linkedin.gms.factory.common"}, | ||
| excludeFilters = {@ComponentScan.Filter(type = FilterType.ASSIGNABLE_TYPE, classes = ScheduledAnalyticsFactory.class), | ||
| @ComponentScan.Filter(type = FilterType.ASSIGNABLE_TYPE, classes = SiblingGraphServiceFactory.class)} |
There was a problem hiding this comment.
not sure why this needs to be excluded as part of this PR
There was a problem hiding this comment.
They are being injected through other classes which means that when running this in standalone mode you have multiple sources for the same beans.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Purpose of this PR is to remove the schema registry as a hard dependency from DataHub.
In order to do that, the PR creates a new module
kafka-avro-serdewhich implements Kafka-compatibleSerializer&Deserializerclasses.Also included is a static, internal light schema registry implementation to know how to serde DataHub's Avro records (MCP, MCL and it's variants).
Based on #5232, kudos to @tmnd1991!