Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ingest): add timestamps for snowflake objects #6570

Merged
merged 5 commits into from
Dec 7, 2022
Merged

feat(ingest): add timestamps for snowflake objects #6570

merged 5 commits into from
Dec 7, 2022

Conversation

mayurinehate
Copy link
Collaborator

@mayurinehate mayurinehate commented Nov 29, 2022 •
edited
Loading

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Nov 29, 2022
@github-actions
Copy link

github-actions bot commented Nov 29, 2022 •
edited
Loading

Unit Test Results (metadata ingestion)

       8 files  ±0         8 suites  ±0   1h 4m 21s ⏱️ + 3m 55s
   752 tests ±0     750 ✔️ ±0  2 💤 ±0  0 ❌ ±0 
1 506 runs  ±0  1 501 ✔️ ±0  5 💤 ±0  0 ❌ ±0 

Results for commit 0d76a00. ± Comparison against base commit eeb7a9d.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Nov 29, 2022 •
edited
Loading

Unit Test Results (build & test)

633 tests  ±0   629 ✔️ ±0   15m 53s ⏱️ +6s
162 suites ±0       4 💤 ±0 
162 files   ±0       0 ❌ ±0 

Results for commit 0d76a00. ± Comparison against base commit eeb7a9d.

♻️ This comment has been updated with latest results.

@jjoyce0510 jjoyce0510 requested a review from treff7es November 29, 2022 21:21
@mayurinehate mayurinehate force-pushed the snowflake_timestamps_external_url branch from f0353b8 to e0c35dc Compare November 30, 2022 06:31
@mayurinehate mayurinehate changed the title feat(ingest): add external url and timestamps for snowflake objects feat(ingest): add timestamps for snowflake objects Nov 30, 2022
@mayurinehate mayurinehate force-pushed the snowflake_timestamps_external_url branch from 6248b60 to 50ae791 Compare December 1, 2022 07:00
@mayurinehate mayurinehate marked this pull request as ready for review December 1, 2022 07:06
@mayurinehate mayurinehate force-pushed the snowflake_timestamps_external_url branch from ad3a228 to b3104d9 Compare December 2, 2022 09:52
@hsheth2
Copy link
Collaborator

hsheth2 commented Dec 5, 2022

@mayurinehate looks like there's a conflict on this one

treff7es
treff7es approved these changes Dec 6, 2022
View reviewed changes
Copy link
Contributor

@treff7es treff7es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

treff7es
treff7es previously requested changes Dec 6, 2022
View reviewed changes
Copy link
Contributor

@treff7es treff7es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mayurinehate there is some merge conflict

@mayurinehate mayurinehate force-pushed the snowflake_timestamps_external_url branch from b3104d9 to 915756d Compare December 7, 2022 10:43
@mayurinehate
feat(ingest): add timestamps for snowflake objects
8df9157 
add query to populate last altered time of snowflake database

add note in updating datahub doc
@mayurinehate mayurinehate force-pushed the snowflake_timestamps_external_url branch from 915756d to 8df9157 Compare December 7, 2022 12:22
hsheth2
hsheth2 approved these changes Dec 7, 2022
View reviewed changes
docs/how/updating-datahub.md Outdated Show resolved Hide resolved
@hsheth2 hsheth2 dismissed treff7es’s stale review December 7, 2022 17:36

The merge conflicts have been resolved.

@hsheth2 hsheth2 merged commit 9e3267a into datahub-project:master Dec 7, 2022
cccs-Dustin pushed a commit to CybercentreCanada/datahub that referenced this pull request Feb 1, 2023
@mayurinehate @treff7es
@hsheth2 @cccs-Dustin
feat(ingest): add timestamps for snowflake objects (datahub-project#6570
e851055 
)

Co-authored-by: Tamas Nemeth <[email protected]>
Co-authored-by: Harshal Sheth <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@treff7es treff7es treff7es left review comments

@hsheth2 hsheth2 hsheth2 approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mayurinehate @hsheth2 @treff7es