Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ingest): restrict snowflake's sqlalchemy dep #6579

Merged
merged 1 commit into from
Nov 30, 2022

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Nov 30, 2022

Related to snowflakedb/snowflake-sqlalchemy#350.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Nov 30, 2022
@github-actions
Copy link

Unit Test Results (metadata ingestion)

       8 files  ±  0         8 suites  ±0   1h 1m 18s ⏱️ -7s
   765 tests  -   2     763 ✔️ +  1  2 💤 ±0  0  - 1 
1 532 runs  +22  1 527 ✔️ +31  5 💤 ±0  0  - 1 

Results for commit 4da10cf. ± Comparison against base commit 329ecb8.

This pull request removes 2 tests.
tests.unit.test_snowflake_beta_source
tests.unit.test_snowflake_source

@github-actions
Copy link

Unit Test Results (build & test)

621 tests  ±0   617 ✔️ ±0   15m 37s ⏱️ -20s
157 suites ±0       4 💤 ±0 
157 files   ±0       0 ±0 

Results for commit 4da10cf. ± Comparison against base commit 329ecb8.

Copy link
Contributor

@treff7es treff7es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@treff7es treff7es merged commit 1366724 into datahub-project:master Nov 30, 2022
cccs-Dustin pushed a commit to CybercentreCanada/datahub that referenced this pull request Feb 1, 2023
@hsheth2 hsheth2 deleted the snowflake-version-fix branch February 14, 2024 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants