Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ingest): add external url for snowflake objects #6580

Merged
merged 4 commits into from
Dec 2, 2022
Merged

feat(ingest): add external url for snowflake objects #6580

merged 4 commits into from
Dec 2, 2022

Conversation

mayurinehate
Copy link
Collaborator

@mayurinehate mayurinehate commented Nov 30, 2022 •
edited
Loading

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Nov 30, 2022
@github-actions
Copy link

github-actions bot commented Nov 30, 2022 •
edited
Loading

Unit Test Results (metadata ingestion)

       8 files         8 suites   58m 55s ⏱️
   766 tests    764 ✔️ 2 💤 0 ❌
1 534 runs  1 529 ✔️ 5 💤 0 ❌

Results for commit 2a24552.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Nov 30, 2022 •
edited
Loading

Unit Test Results (build & test)

621 tests  ±0   617 ✔️ ±0   15m 41s ⏱️ -41s
157 suites ±0       4 💤 ±0 
157 files   ±0       0 ❌ ±0 

Results for commit 2a24552. ± Comparison against base commit 4f7b5ac.

♻️ This comment has been updated with latest results.

hsheth2
hsheth2 approved these changes Dec 1, 2022
View reviewed changes
Copy link
Collaborator

@hsheth2 hsheth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

metadata-ingestion/src/datahub/ingestion/source/snowflake/snowflake_v2.py Show resolved Hide resolved
@mayurinehate mayurinehate force-pushed the snowflake_external_url branch from 954945e to 817e3f0 Compare December 2, 2022 14:31
@hsheth2 hsheth2 merged commit 1689212 into datahub-project:master Dec 2, 2022
cccs-Dustin pushed a commit to CybercentreCanada/datahub that referenced this pull request Feb 1, 2023
@mayurinehate @cccs-Dustin
feat(ingest): add external url for snowflake objects (datahub-project…
cdb866e 
…#6580)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjoyce0510 jjoyce0510 jjoyce0510 left review comments

@hsheth2 hsheth2 hsheth2 approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mayurinehate @hsheth2 @jjoyce0510