Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(test): fix delete smoke test #6585

Merged
merged 1 commit into from
Nov 30, 2022
Merged

fix(test): fix delete smoke test #6585

merged 1 commit into from
Nov 30, 2022

Conversation

david-leifker
Copy link
Collaborator

@david-leifker david-leifker commented Nov 30, 2022 •
edited
Loading

This is required since a delete executed for the healthcheck prevents the actual test from working because elasticsearch recalls that the fixture was deleted for around 60s.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the smoke_test Contains changes related to smoke tests label Nov 30, 2022
pedro93
pedro93 approved these changes Nov 30, 2022
View reviewed changes
Copy link
Collaborator

@pedro93 pedro93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please wait for CI to pass.

@github-actions
Copy link

Unit Test Results (build & test)

621 tests  ±0   617 ✔️ ±0   15m 40s ⏱️ -9s
157 suites ±0       4 💤 ±0 
157 files   ±0       0 ❌ ±0 

Results for commit c910eed. ± Comparison against base commit f69b469.

@david-leifker david-leifker merged commit 00e8750 into datahub-project:master Nov 30, 2022
cccs-Dustin pushed a commit to CybercentreCanada/datahub that referenced this pull request Feb 1, 2023
@david-leifker @cccs-Dustin
fix(test): fix delete smoke test (datahub-project#6585)
f685a98
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedro93 pedro93 pedro93 approved these changes

@jjoyce0510 jjoyce0510 Awaiting requested review from jjoyce0510

Assignees
No one assigned
Labels
smoke_test Contains changes related to smoke tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@david-leifker @pedro93