-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(security): security version updates #6602
fix(security): security version updates #6602
Conversation
@@ -184,6 +191,7 @@ configure(subprojects.findAll {! it.name.startsWith('spark-lineage') }) { | |||
|
|||
configurations.all { | |||
exclude group: "io.netty", module: "netty" | |||
exclude group: "log4j", module: "log4j" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does seem to do something, what is not covered here is the -core and -api modules, but those are locked at the latest version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :) minor comment for consistency
@@ -10,7 +10,7 @@ dependencies { | |||
exclude group: 'com.google.guava', module: 'guava' | |||
} | |||
compile 'com.google.guava:guava:27.0.1-jre' | |||
compile 'com.fasterxml.jackson.core:jackson-databind:2.9.10.7' | |||
compile 'com.fasterxml.jackson.dataformat:jackson-dataformat-yaml:2.8.11' | |||
compile 'com.fasterxml.jackson.core:jackson-databind:2.13.4.2' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Variable replacement here too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can't be done in the buildSrc
like normal, unless the version config is refactored out of its current location.
Checklist