fix(logging): Remove lombok as source of slf4j-api #6616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-leifker
force-pushed
the
fix-logging
branch
from
e7165f9 to
61b99e6
Compare
david-leifker
force-pushed
the
fix-logging
branch
2 times, most recently
from
9d102c9 to
2ef5aa3
Compare
david-leifker
added
platform
|
Looks like tests are failing, probably need a testCompile dep on logback |
…eOnly where possible
david-leifker
force-pushed
the
fix-logging
branch
from
2ef5aa3 to
5f385f1
Compare
5 tasks
jjoyce0510
reviewed
Dec 5, 2022
| } | ||
|
|
||
| task run(type: JavaExec, dependsOn: build) { | ||
| main = "org.eclipse.jetty.runner.Runner" | ||
| args = [war.archivePath] | ||
| classpath configurations.jetty8 | ||
| classpath configurations.jetty9 |
jjoyce0510
reviewed
Dec 5, 2022
| @@ -15,7 +15,7 @@ dependencies { | |||
| compile externalDependency.gson | |||
| compile externalDependency.kafkaClients | |||
| compile externalDependency.kafkaAvroSerde | |||
| compile externalDependency.lombok | |||
| compileOnly externalDependency.lombok | |||
jjoyce0510
reviewed
Dec 5, 2022
| 'log4jApi': 'org.apache.logging.log4j:log4j-api:2.19.0', | ||
| 'logbackClassic': "ch.qos.logback:logback-classic:$logbackClassic", | ||
| 'slf4jApi': "org.slf4j:slf4j-api:$slf4jVersion", | ||
| 'log4jCore': "org.apache.logging.log4j:log4j-core:$log4jVersion", |
There was a problem hiding this comment.
This ecosystem is still a bit convoluted to me, but why do we need all of these? Shouldn't we ideally just use logback and SLF4J?
Also, what is the purpose of log4j12Api?
There was a problem hiding this comment.
Unfortunately some dependencies include the need for the older log4j api and the actual log4j impl still. It might be possible to update and/or replace those overtime however updating to latest works for now.
jjoyce0510
approved these changes
Dec 5, 2022
|
cccs-Dustin
pushed a commit
to CybercentreCanada/datahub
that referenced
this pull request
Feb 1, 2023
…eOnly where possible (datahub-project#6616)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove lombok as source of slf4j-api, convert to compileOnly where possible
Checklist