Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui) Fix double scroll in embedded list search sections #6618

Merged
merged 1 commit into from
Dec 2, 2022
Merged

fix(ui) Fix double scroll in embedded list search sections #6618

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion datahub-web-react/src/app/recommendations/renderer/component/EntityNameList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ const StyledCheckbox = styled(Checkbox)`
`;

const StyledList = styled(List)`
overflow-y: scroll;
overflow-y: auto;
height: 100%;
margin-top: -1px;
box-shadow: ${(props) => props.theme.styles['box-shadow']};
Expand Down
6 changes: 2 additions & 4 deletions datahub-web-react/src/app/search/AdvancedSearchFilters.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,9 @@ import { FIELDS_THAT_USE_CONTAINS_OPERATOR, UnionType } from './utils/constants'
import { AdvancedSearchAddFilterSelect } from './AdvancedSearchAddFilterSelect';

export const SearchFilterWrapper = styled.div`
min-height: 100%;
flex: 1;
padding: 6px 12px 10px 12px;
overflow: auto;
margin-top: 6px;
margin-left: 12px;
margin-right: 12px;

&::-webkit-scrollbar {
height: 12px;
Expand Down
6 changes: 4 additions & 2 deletions datahub-web-react/src/app/search/SearchFiltersSection.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@ type Props = {
};

const FiltersContainer = styled.div`
display: block;
display: flex;
flex-direction: column;
max-width: 260px;
min-width: 260px;
overflow-wrap: break-word;
Expand Down Expand Up @@ -45,7 +46,8 @@ const FiltersHeader = styled.div`
`;

const SearchFilterContainer = styled.div`
padding-top: 10px;
flex: 1;
overflow: auto;
`;

// This component renders the entire filters section that allows toggling
Expand Down
1 change: 1 addition & 0 deletions datahub-web-react/src/app/search/SimpleSearchFilters.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import { SimpleSearchFilter } from './SimpleSearchFilter';
const TOP_FILTERS = ['degree', 'entity', 'tags', 'glossaryTerms', 'domains', 'owners'];

export const SearchFilterWrapper = styled.div`
padding-top: 10px;
max-height: 100%;
overflow: auto;

Expand Down