Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: move rfcs to separate repo #6621

Merged
merged 6 commits into from
Dec 6, 2022
Merged

docs: move rfcs to separate repo #6621

merged 6 commits into from
Dec 6, 2022

Conversation

laulpogan
Copy link
Contributor

@laulpogan laulpogan commented Dec 2, 2022 •
edited by hsheth2
Loading

Moved to https://github.com/datahub-project/rfcs

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added docs Issues and Improvements to docs product PR or Issue related to the DataHub UI/UX labels Dec 2, 2022
@github-actions
Copy link

github-actions bot commented Dec 2, 2022 •
edited
Loading

Unit Test Results (build & test)

633 tests  +12   629 ✔️ +12   15m 39s ⏱️ -1s
162 suites +  5       4 💤 ±  0 
162 files   +  5       0 ❌ ±  0 

Results for commit 9ac93c5. ± Comparison against base commit 8ff35b8.

This pull request removes 4 and adds 16 tests. Note that renamed tests count towards both. 
com.datahub.authorization.ranger.RangerAuthorizerTest ‑ testAuthorizationAllow
com.datahub.authorization.ranger.RangerAuthorizerTest ‑ testAuthorizationDeny
com.datahub.authorizer.plugin.ranger.TestDataHubRangerAuthPlugin ‑ testLookupResource
com.datahub.authorizer.plugin.ranger.TestDataHubRangerAuthPlugin ‑ testValidateConfig

com.datahub.plugins.auth.TestConfig ‑ testConfig
com.datahub.plugins.auth.TestConfigProvider ‑ testConfigurationLoading
com.datahub.plugins.auth.TestConfigValidationUtils ‑ testListShouldNotBeEmpty
com.datahub.plugins.auth.TestConfigValidationUtils ‑ testListShouldNotHaveDuplicate
com.datahub.plugins.auth.TestConfigValidationUtils ‑ testMapShouldNotBeEmpty
com.datahub.plugins.auth.TestConfigValidationUtils ‑ testWhiteSpacesValidation
com.datahub.plugins.auth.TestIsolatedClassLoader ‑ testAuthenticatorPlugin
com.datahub.plugins.auth.TestIsolatedClassLoader ‑ testAuthorizerPlugin
com.datahub.plugins.auth.TestIsolatedClassLoader ‑ testDuplicatePluginName
com.datahub.plugins.auth.TestIsolatedClassLoader ‑ testIncorrectImplementation
…

♻️ This comment has been updated with latest results.

@hsheth2 hsheth2 changed the title Docs remove rfcs docs: move rfcs to separate repo Dec 5, 2022
hsheth2
hsheth2 approved these changes Dec 5, 2022
View reviewed changes
docs-website/generateDocsDir.ts Outdated
@@ -116,6 +116,7 @@ function list_markdown_files(): string[] {
// Keep main docs for kubernetes, but skip the inner docs.
/^datahub-kubernetes\//,
// Various other docs/directories to ignore.
/^rfc\//, // We want RFC's active on git, but not indexed/searched/in nav docs
Copy link
Collaborator

@hsheth2 hsheth2 Dec 2, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

outdated

@anshbansal anshbansal added the community-contribution PR or Issue raised by member(s) of DataHub Community label Dec 6, 2022
@laulpogan laulpogan merged commit dbb4c84 into datahub-project:master Dec 6, 2022
cccs-Dustin pushed a commit to CybercentreCanada/datahub that referenced this pull request Feb 1, 2023
@laulpogan @cccs-Dustin
docs: move rfcs to separate repo (datahub-project#6621)
082debd 
* moving rfc's

* ignoring rfc/

* moving RFC

* updating rfc policy page

* removing unused filter patter

* removing unused filter patter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

@shirshanka shirshanka Awaiting requested review from shirshanka

Assignees
No one assigned
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community docs Issues and Improvements to docs product PR or Issue related to the DataHub UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@laulpogan @hsheth2 @anshbansal